Re: [PATCH v5 05/13] drm/xe/cper: Log CPER records for aggregate counter retrieval

[Raag Jadav <raag.jadav@intel.com>]

On Fri, Oct 23, 2026 at 10:04:27AM +0530, Badal Nilawar wrote:
> Log CPER records for aggregate counter retrieval from userspace when
> cper_on_query sysfs is enabled.

...

> +static enum xe_sigid ras_comp_to_hw_sigid(u8 component)

Group these with other 'component' switcheroos, preferably above
ras_status_to_errno().

> +{
> +	switch (component) {
> +	case XE_RAS_COMP_DEVICE_MEMORY:
> +		return XE_SIGID_DEVICE_MEMORY;
> +	case XE_RAS_COMP_CORE_COMPUTE:
> +		return XE_SIGID_CORE_COMPUTE;
> +	case XE_RAS_COMP_PCIE:
> +		return XE_SIGID_PCIE;
> +	case XE_RAS_COMP_FABRIC:
> +		return XE_SIGID_FABRIC;
> +	case XE_RAS_COMP_SOC_INTERNAL:
> +		return XE_SIGID_SOC_INTERNAL;
> +	default:
> +		return XE_SIGID_HW;
> +	}
> +}
> +
> +static u8 ras_sev_to_cper_sev(u8 ras_sev)

Ditto, move this above drm_to_xe_ras_component() with other 'severity'
switcheroos. Also use 'severity' as parameter name.

> +{
> +	switch (ras_sev) {
> +	case XE_RAS_SEV_CORRECTABLE:
> +		return CPER_SEV_CORRECTED;
> +	case XE_RAS_SEV_UNCORRECTABLE:
> +		return CPER_SEV_RECOVERABLE;
> +	case XE_RAS_SEV_INFORMATIONAL:
> +		return CPER_SEV_INFORMATIONAL;
> +	default:
> +		return CPER_SEV_RECOVERABLE;
> +	}
> +}

...

> @@ -1248,5 +1285,9 @@ int xe_ras_init(struct xe_device *xe)
>  	if (ret)
>  		xe_err(xe, "Failed to create GPU health sysfs, err=%d\n", ret);
>  
> +	ret = xe_cper_sysfs_init(xe);
> +	if (ret)
> +		xe_err(xe, "Failed to create cper_on_query sysfs, err=%d\n", ret);

This function is int now, so let's not hide bugs and return the error.

Raag

> +
>  	return devm_add_action_or_reset(xe->drm.dev, ras_fini, xe);
>  }
> -- 
> 2.54.0
>