All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <jszhang@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Conor Dooley <conor.dooley@microchip.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: RISCV_ISA_SV48 and RISCV_ISA_SV57 should depend on MMU
Date: Thu, 15 Oct 2026 07:28:00 +0800	[thread overview]
Message-ID: <atAQAI0WWtwh8kvf@xhacker> (raw)
In-Reply-To: <1b1ca4208d725ae0bb834a61636e48728d79cf80.1791973171.git.geert+renesas@glider.be>

On Wed, Oct 14, 2026 at 12:20:39PM +0200, Geert Uytterhoeven wrote:
> These options are irreleant for nommu systems.
> 
> Fixes: 36de74049ec8cb1a ("riscv: introduce RISCV_ISA_SV48 and RISCV_ISA_SV57")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/riscv/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 15f6e67c60410a87..15beeb4690aebcc4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -605,7 +605,7 @@ config RISCV_ISA_SSQOSID
>  
>  config RISCV_ISA_SV48
>  	bool "Page-Based 48-bit Virtual-Memory System"
> -	depends on 64BIT
> +	depends on 64BIT && MMU
>  	default y
>  	help
>  	  Add support for the Page-Based 48-bit Virtual-Memory System.
> @@ -617,7 +617,7 @@ config RISCV_ISA_SV48
>  
>  config RISCV_ISA_SV57
>  	bool "Page-Based 57-bit Virtual-Memory System"
> -	depends on 64BIT
> +	depends on 64BIT && MMU

hmm, I think we also need to make RISCV_ISA_SV57 depend on
RISCV_ISA_SV48. Otherwise, there's a case: RISCV_ISA_SV57 &&
!RISCV_ISA_SV48. Human won't make this wrong combination, but
the random config can.

with that change,
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>

>  	default y
>  	help
>  	  Add support for the Page-Based 57-bit Virtual-Memory System.
> -- 
> 2.43.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <jszhang@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>,
	Conor Dooley <conor.dooley@microchip.com>,
	linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: RISCV_ISA_SV48 and RISCV_ISA_SV57 should depend on MMU
Date: Thu, 15 Oct 2026 07:28:00 +0800	[thread overview]
Message-ID: <atAQAI0WWtwh8kvf@xhacker> (raw)
In-Reply-To: <1b1ca4208d725ae0bb834a61636e48728d79cf80.1791973171.git.geert+renesas@glider.be>

On Wed, Oct 14, 2026 at 12:20:39PM +0200, Geert Uytterhoeven wrote:
> These options are irreleant for nommu systems.
> 
> Fixes: 36de74049ec8cb1a ("riscv: introduce RISCV_ISA_SV48 and RISCV_ISA_SV57")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/riscv/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 15f6e67c60410a87..15beeb4690aebcc4 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -605,7 +605,7 @@ config RISCV_ISA_SSQOSID
>  
>  config RISCV_ISA_SV48
>  	bool "Page-Based 48-bit Virtual-Memory System"
> -	depends on 64BIT
> +	depends on 64BIT && MMU
>  	default y
>  	help
>  	  Add support for the Page-Based 48-bit Virtual-Memory System.
> @@ -617,7 +617,7 @@ config RISCV_ISA_SV48
>  
>  config RISCV_ISA_SV57
>  	bool "Page-Based 57-bit Virtual-Memory System"
> -	depends on 64BIT
> +	depends on 64BIT && MMU

hmm, I think we also need to make RISCV_ISA_SV57 depend on
RISCV_ISA_SV48. Otherwise, there's a case: RISCV_ISA_SV57 &&
!RISCV_ISA_SV48. Human won't make this wrong combination, but
the random config can.

with that change,
Reviewed-by: Jisheng Zhang <jszhang@kernel.org>

>  	default y
>  	help
>  	  Add support for the Page-Based 57-bit Virtual-Memory System.
> -- 
> 2.43.0
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-10-14 23:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-14 10:20 [PATCH] riscv: RISCV_ISA_SV48 and RISCV_ISA_SV57 should depend on MMU Geert Uytterhoeven
2026-10-14 10:20 ` Geert Uytterhoeven
2026-10-14 23:28 ` Jisheng Zhang [this message]
2026-10-14 23:28   ` Jisheng Zhang
2026-10-15  7:43   ` Geert Uytterhoeven
2026-10-15  7:43     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atAQAI0WWtwh8kvf@xhacker \
    --to=jszhang@kernel.org \
    --cc=alex@ghiti.fr \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.