All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc
@ 2026-10-11  4:51 Arnav Kapoor
  2026-10-11 15:09 ` Maxwell Doose
  2026-10-15  8:45 ` Nuno Sá
  0 siblings, 2 replies; 3+ messages in thread
From: Arnav Kapoor @ 2026-10-11  4:51 UTC (permalink / raw)
  To: Nuno Sá, Michael Hennerich, Jonathan Cameron
  Cc: David Lechner, Andy Shevchenko, Rodrigo Alencar, linux, linux-iio,
	linux-kernel, Arnav Kapoor

The kernel-doc for struct ad5686_chip_info describes a member called
@channel, but the member is named channels. W=1 builds report:

  Warning: drivers/iio/dac/ad5686.h:95 struct member 'channels' not
  described in 'ad5686_chip_info'
  Warning: drivers/iio/dac/ad5686.h:95 Excess struct member 'channel'
  description in 'ad5686_chip_info'

Rename the entry to match the struct member.

Fixes: 0357e488b825 ("iio:dac:ad5686: Refactor the driver")
Assisted-by: LLM
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
---
Comment-only change, checked with scripts/kernel-doc -Wall.

 drivers/iio/dac/ad5686.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h
index 482bc70515f7..4f2ac1e96643 100644
--- a/drivers/iio/dac/ad5686.h
+++ b/drivers/iio/dac/ad5686.h
@@ -85,7 +85,7 @@ struct ad5686_bus_ops {
  * struct ad5686_chip_info - chip specific information
  * @int_vref_mv:	the internal reference voltage
  * @num_channels:	number of channels
- * @channel:		channel specification
+ * @channels:		channel specification
  * @regmap_type:	register map layout variant
  */
 struct ad5686_chip_info {
-- 
2.53.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc
  2026-10-11  4:51 [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc Arnav Kapoor
@ 2026-10-11 15:09 ` Maxwell Doose
  2026-10-15  8:45 ` Nuno Sá
  1 sibling, 0 replies; 3+ messages in thread
From: Maxwell Doose @ 2026-10-11 15:09 UTC (permalink / raw)
  To: Arnav Kapoor, Nuno Sá, Michael Hennerich, Jonathan Cameron
  Cc: David Lechner, Andy Shevchenko, Rodrigo Alencar, linux, linux-iio,
	linux-kernel

On Sat Oct 10, 2026 at 11:51 PM CDT
Arnav Kapoor <kapoorarnav43@gmail.com> wrote:

> The kernel-doc for struct ad5686_chip_info describes a member called
> @channel, but the member is named channels. W=1 builds report:
>
>   Warning: drivers/iio/dac/ad5686.h:95 struct member 'channels' not
>   described in 'ad5686_chip_info'
>   Warning: drivers/iio/dac/ad5686.h:95 Excess struct member 'channel'
>   description in 'ad5686_chip_info'
>
> Rename the entry to match the struct member.
>
> Fixes: 0357e488b825 ("iio:dac:ad5686: Refactor the driver")
> Assisted-by: LLM
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---
> Comment-only change, checked with scripts/kernel-doc -Wall.
>

Reviewed-by: Maxwell Doose <maxwell@maxwelld.cc>

Thanks,
Max

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc
  2026-10-11  4:51 [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc Arnav Kapoor
  2026-10-11 15:09 ` Maxwell Doose
@ 2026-10-15  8:45 ` Nuno Sá
  1 sibling, 0 replies; 3+ messages in thread
From: Nuno Sá @ 2026-10-15  8:45 UTC (permalink / raw)
  To: Arnav Kapoor
  Cc: Michael Hennerich, Jonathan Cameron, David Lechner,
	Andy Shevchenko, Rodrigo Alencar, linux, linux-iio, linux-kernel

On Sun, Oct 11, 2026 at 10:21:47AM +0530, Arnav Kapoor wrote:
> The kernel-doc for struct ad5686_chip_info describes a member called
> @channel, but the member is named channels. W=1 builds report:
> 
>   Warning: drivers/iio/dac/ad5686.h:95 struct member 'channels' not
>   described in 'ad5686_chip_info'
>   Warning: drivers/iio/dac/ad5686.h:95 Excess struct member 'channel'
>   description in 'ad5686_chip_info'
> 
> Rename the entry to match the struct member.
> 
> Fixes: 0357e488b825 ("iio:dac:ad5686: Refactor the driver")
> Assisted-by: LLM
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---

Reviewed-by: Nuno Sá <nuno.sa@analog.com>

> Comment-only change, checked with scripts/kernel-doc -Wall.
> 
>  drivers/iio/dac/ad5686.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h
> index 482bc70515f7..4f2ac1e96643 100644
> --- a/drivers/iio/dac/ad5686.h
> +++ b/drivers/iio/dac/ad5686.h
> @@ -85,7 +85,7 @@ struct ad5686_bus_ops {
>   * struct ad5686_chip_info - chip specific information
>   * @int_vref_mv:	the internal reference voltage
>   * @num_channels:	number of channels
> - * @channel:		channel specification
> + * @channels:		channel specification
>   * @regmap_type:	register map layout variant
>   */
>  struct ad5686_chip_info {
> -- 
> 2.53.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-15  8:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-11  4:51 [PATCH] iio: dac: ad5686: fix channels member name in kernel-doc Arnav Kapoor
2026-10-11 15:09 ` Maxwell Doose
2026-10-15  8:45 ` Nuno Sá

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.