From: Daniel Golle <daniel@makrotopia.org>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Dafna Hirschfeld <dafna@fastmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
michael.riesch@collabora.com, stefan.klug@ideasonboard.com,
mehdi.djait@linux.intel.com, xuhf@rock-chips.com,
zyc@rock-chips.com, dalong.deng@rock-chips.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: add ISP nodes to rk3588
Date: Fri, 16 Oct 2026 17:06:50 +0100 [thread overview]
Message-ID: <atJLmq50uRVfeuyX@makrotopia.org> (raw)
In-Reply-To: <20260827-rkisp2-v3-5-e91ff0a604d6@ideasonboard.com>
On Thu, Aug 27, 2026 at 07:48:34PM +0900, Paul Elder wrote:
> From: Xu Hongfei <xuhf@rock-chips.com>
>
> Add device tree nodes for the ISP and their iommus on the RK3588.
[...]
> + isp0: isp@fdcb0000 {
> + compatible = "rockchip,rk3588-isp";
> + reg = <0x0 0xfdcb0000 0x0 0x7f00>;
> + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "isp_irq", "mi_irq";
Three interrupts with two names, while the binding in patch 4 has
maxItems: 2 and isp1 below lists two, so dtbs_check rejects isp0. If
134 is the MIPI line it needs a name and an entry in the binding (the
RV1126 has that third line and the driver can use it for the CSI-2
receiver errors); otherwise drop it.
Best regards,
Daniel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Golle <daniel@makrotopia.org>
To: Paul Elder <paul.elder@ideasonboard.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Dafna Hirschfeld <dafna@fastmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
michael.riesch@collabora.com, stefan.klug@ideasonboard.com,
mehdi.djait@linux.intel.com, xuhf@rock-chips.com,
zyc@rock-chips.com, dalong.deng@rock-chips.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 5/5] arm64: dts: rockchip: add ISP nodes to rk3588
Date: Fri, 16 Oct 2026 17:06:50 +0100 [thread overview]
Message-ID: <atJLmq50uRVfeuyX@makrotopia.org> (raw)
In-Reply-To: <20260827-rkisp2-v3-5-e91ff0a604d6@ideasonboard.com>
On Thu, Aug 27, 2026 at 07:48:34PM +0900, Paul Elder wrote:
> From: Xu Hongfei <xuhf@rock-chips.com>
>
> Add device tree nodes for the ISP and their iommus on the RK3588.
[...]
> + isp0: isp@fdcb0000 {
> + compatible = "rockchip,rk3588-isp";
> + reg = <0x0 0xfdcb0000 0x0 0x7f00>;
> + interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH 0>,
> + <GIC_SPI 134 IRQ_TYPE_LEVEL_HIGH 0>;
> + interrupt-names = "isp_irq", "mi_irq";
Three interrupts with two names, while the binding in patch 4 has
maxItems: 2 and isp1 below lists two, so dtbs_check rejects isp0. If
134 is the MIPI line it needs a name and an entry in the binding (the
RV1126 has that third line and the driver can use it for the CSI-2
receiver errors); otherwise drop it.
Best regards,
Daniel
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-10-16 16:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 10:48 [PATCH v3 0/5] media: rockchip: rkisp2: Add driver for ISP on Rk3588 Paul Elder
2026-08-27 10:48 ` Paul Elder
2026-08-27 10:48 ` [PATCH v3 1/5] media: rockchip: rkisp2: Add rkisp2 driver Paul Elder
2026-10-16 16:06 ` Daniel Golle
2026-10-16 16:06 ` Daniel Golle
2026-08-27 10:48 ` [PATCH v3 2/5] media: rkisp2: Add parameters output video node Paul Elder
2026-08-27 10:48 ` Paul Elder
2026-08-27 11:05 ` sashiko-bot
2026-10-16 16:06 ` Daniel Golle
2026-10-16 16:06 ` Daniel Golle
2026-08-27 10:48 ` [PATCH v3 3/5] media: rkisp2: Add statistics capture " Paul Elder
2026-08-27 10:48 ` Paul Elder
2026-08-27 11:08 ` sashiko-bot
2026-10-16 16:06 ` Daniel Golle
2026-10-16 16:06 ` Daniel Golle
2026-08-27 10:48 ` [PATCH v3 4/5] dt-bindings: media: Add rockchip rkisp2 Paul Elder
2026-08-27 10:48 ` Paul Elder
2026-08-27 10:57 ` sashiko-bot
2026-08-27 16:43 ` Conor Dooley
2026-08-27 16:43 ` Conor Dooley
2026-08-27 10:48 ` [PATCH v3 5/5] arm64: dts: rockchip: add ISP nodes to rk3588 Paul Elder
2026-08-27 10:48 ` Paul Elder
2026-08-27 10:57 ` sashiko-bot
2026-10-16 16:06 ` Daniel Golle [this message]
2026-10-16 16:06 ` Daniel Golle
2026-10-16 16:06 ` [PATCH v3 0/5] media: rockchip: rkisp2: Add driver for ISP on Rk3588 Daniel Golle
2026-10-16 16:06 ` Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atJLmq50uRVfeuyX@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=conor+dt@kernel.org \
--cc=dafna@fastmail.com \
--cc=dalong.deng@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=mehdi.djait@linux.intel.com \
--cc=michael.riesch@collabora.com \
--cc=paul.elder@ideasonboard.com \
--cc=robh@kernel.org \
--cc=stefan.klug@ideasonboard.com \
--cc=xuhf@rock-chips.com \
--cc=zyc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.