[Buildroot] [PATCH] package/erlang: enable uClibc support

[Buildroot] [PATCH] package/erlang: enable uClibc support

[Waldemar Brodkorb]

uClibc support was disabled in commit:
fb72418160417e9e872f626c356f898bff49cf48.
This problem is solved in 1.0.59. So in internal
Buildroot toolchains and external Bootlin toolchains.

The change can be backported to stable branches.

Tested with aarch64 and external uClibc Bootlin toolchain.

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/erlang/Config.in | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/erlang/Config.in b/package/erlang/Config.in
index 724f91123b..d3fe0dbec1 100644
--- a/package/erlang/Config.in
+++ b/package/erlang/Config.in
@@ -15,11 +15,11 @@ config BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	# erlang needs host-erlang
 	depends on BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
 
-comment "erlang needs a glibc or musl toolchain w/ dynamic library, threads, wchar"
+comment "erlang needs a toolchain w/ dynamic library, threads, wchar"
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS \
-		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_UCLIBC
+		|| !BR2_USE_WCHAR
 
 config BR2_PACKAGE_ERLANG
 	bool "erlang"
@@ -27,7 +27,6 @@ config BR2_PACKAGE_ERLANG
 	depends on BR2_USE_WCHAR
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HAS_THREADS
-	depends on !BR2_TOOLCHAIN_USES_UCLIBC
 	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
 	select BR2_PACKAGE_ZLIB
 	help
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH] package/erlang: enable uClibc support

[Thomas Perale via buildroot]

Hello,

Also tested with the erlang test modified to use uclibc:

```diff
diff --git a/support/testing/tests/package/test_erlang.py b/support/testing/tests/package/test_erlang.py
index a765cec843..e39bd94b4e 100644
--- a/support/testing/tests/package/test_erlang.py
+++ b/support/testing/tests/package/test_erlang.py
@@ -4,8 +4,15 @@ import infra.basetest
 
 
 class TestErlang(infra.basetest.BRTest):
-    config = infra.basetest.BASIC_TOOLCHAIN_CONFIG + \
+    config = \
         """
+        BR2_arm=y
+        BR2_cortex_a9=y
+        BR2_ARM_ENABLE_VFP=y
+        BR2_ARM_EABIHF=y
+        BR2_TOOLCHAIN_EXTERNAL=y
+        BR2_TOOLCHAIN_EXTERNAL_BOOTLIN=y
+        BR2_TOOLCHAIN_EXTERNAL_BOOTLIN_ARMV7_EABIHF_UCLIBC_BLEEDING_EDGE=y
         BR2_PACKAGE_ERLANG=y
         BR2_TARGET_ROOTFS_CPIO=y
         # BR2_TARGET_ROOTFS_TAR is not set
```

Reviewed-by: Thomas Perale <thomas.perale@mind.be>

Best regards,
PERALE Thomas

In reply of:
> uClibc support was disabled in commit:
> fb72418160417e9e872f626c356f898bff49cf48.
> This problem is solved in 1.0.59. So in internal
> Buildroot toolchains and external Bootlin toolchains.
> 
> The change can be backported to stable branches.
> 
> Tested with aarch64 and external uClibc Bootlin toolchain.
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>

> ---
>  package/erlang/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/erlang/Config.in b/package/erlang/Config.in
> index 724f91123b..d3fe0dbec1 100644
> --- a/package/erlang/Config.in
> +++ b/package/erlang/Config.in
> @@ -15,11 +15,11 @@ config BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
>  	# erlang needs host-erlang
>  	depends on BR2_PACKAGE_HOST_ERLANG_ARCH_SUPPORTS
>  
> -comment "erlang needs a glibc or musl toolchain w/ dynamic library, threads, wchar"
> +comment "erlang needs a toolchain w/ dynamic library, threads, wchar"
>  	depends on BR2_USE_MMU # fork()
>  	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
>  	depends on BR2_STATIC_LIBS || !BR2_TOOLCHAIN_HAS_THREADS \
> -		|| !BR2_USE_WCHAR || BR2_TOOLCHAIN_USES_UCLIBC
> +		|| !BR2_USE_WCHAR
>  
>  config BR2_PACKAGE_ERLANG
>  	bool "erlang"
> @@ -27,7 +27,6 @@ config BR2_PACKAGE_ERLANG
>  	depends on BR2_USE_WCHAR
>  	depends on !BR2_STATIC_LIBS
>  	depends on BR2_TOOLCHAIN_HAS_THREADS
> -	depends on !BR2_TOOLCHAIN_USES_UCLIBC
>  	depends on BR2_PACKAGE_ERLANG_ARCH_SUPPORTS
>  	select BR2_PACKAGE_ZLIB
>  	help
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot