* [PATCH] Fix getroot.c build on GNU/Hurd @ 2026-10-18 15:30 Samuel Thibault 2026-10-19 15:53 ` Mike Gilbert 0 siblings, 1 reply; 2+ messages in thread From: Samuel Thibault @ 2026-10-18 15:30 UTC (permalink / raw) To: grub-devel; +Cc: bug-hurd os_dev is a const char *, and with recent glibc the qualifier gets propagated through strrchr below, so p needs to be qualified const as well. Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> diff --git a/util/getroot.c b/util/getroot.c index 75a7d5f21..05a2414fe 100644 --- a/util/getroot.c +++ b/util/getroot.c @@ -351,7 +351,7 @@ grub_util_biosdisk_get_grub_dev (const char *os_dev) */ if (ctx.start == (grub_disk_addr_t) -1) { - char *p; + const char *p; char *dri; dri = make_device_name (drive); _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix getroot.c build on GNU/Hurd 2026-10-18 15:30 [PATCH] Fix getroot.c build on GNU/Hurd Samuel Thibault @ 2026-10-19 15:53 ` Mike Gilbert 0 siblings, 0 replies; 2+ messages in thread From: Mike Gilbert @ 2026-10-19 15:53 UTC (permalink / raw) To: The development of GNU GRUB, samuel.thibault; +Cc: bug-hurd On Sun, Oct 18, 2026 at 11:30 AM Samuel Thibault <samuel.thibault@ens-lyon.org> wrote: > > os_dev is a const char *, and with recent glibc the qualifier gets > propagated through strrchr below, so p needs to be qualified const as > well. > > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org> > > diff --git a/util/getroot.c b/util/getroot.c > index 75a7d5f21..05a2414fe 100644 > --- a/util/getroot.c > +++ b/util/getroot.c > @@ -351,7 +351,7 @@ grub_util_biosdisk_get_grub_dev (const char *os_dev) > */ > if (ctx.start == (grub_disk_addr_t) -1) > { > - char *p; > + const char *p; > char *dri; > > dri = make_device_name (drive); > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel GRUB development has moved to freedesktop.org. Please submit patches there. https://gitlab.freedesktop.org/gnu-grub/grub/ _______________________________________________ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-19 15:54 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-10-18 15:30 [PATCH] Fix getroot.c build on GNU/Hurd Samuel Thibault 2026-10-19 15:53 ` Mike Gilbert
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.