All of lore.kernel.org
 help / color / mirror / Atom feed
* `make -R check` fails due to futex_waitv.2 and console_codes.4 being too wide
@ 2026-10-17 19:19 Hugo Buddelmeijer
  2026-10-19  6:20 ` Alejandro Colomar
  0 siblings, 1 reply; 6+ messages in thread
From: Hugo Buddelmeijer @ 2026-10-17 19:19 UTC (permalink / raw)
  To: Alejandro Colomar; +Cc: linux-man

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

Hi Alejandro,

Running `make -R check` fails because the text in futex_waitv.2 and 
console_codes.4 is too wide.

I noticed this when trying to enable the test phase when updating the 
man-pages package in Guix; see https://codeberg.org/guix/guix/pulls/11893

That Guix pull request contains a patch to fix the man-pages so `make 
check` passes; said patch is attached.

Maybe you could device a better patch though, in particular for 
console_codes.  The affected table is much narrower than similar tables, 
so some lines that have to be truncated, would easily fit in one of the 
other tables.  But I couldn't easily figure out what determines the 
column widths, so I didn't fix that.

Also, the Changelog for 6.04 contains some instructions to touch certain 
files to ensure the test suite passes.  I did not attempt to use that 
workaround.

Thanks for maintaining these man pages, they contain such a wealth of 
information.  No need to credit me in case you fix these minor things.

Hugo

[-- Attachment #2: man-pages-fix-make-check.patch --]
[-- Type: text/x-patch, Size: 2737 bytes --]

From 1345875d14b950e6e64b8fd9a8f335efe7ce5ae0 Mon Sep 17 00:00:00 2001
From: Hugo Buddelmeijer <hugo@buddelmeijer.nl>
Date: Sat, 17 Oct 2026 10:47:03 +0200
Subject: [PATCH] man/man2/futex_waitv.2: Fix `make check`.
 man/man4/console_codes.4: Fix `make check`.

---
 man/man2/futex_waitv.2   |  3 ++-
 man/man4/console_codes.4 | 20 +++++++++++++++-----
 2 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/man/man2/futex_waitv.2 b/man/man2/futex_waitv.2
index 4158f297d..acafd2829 100644
--- a/man/man2/futex_waitv.2
+++ b/man/man2/futex_waitv.2
@@ -385,7 +385,8 @@ main(void)
 		clock_gettime(CLOCK_MONOTONIC, &timeout);
 		timeout.tv_sec += 1;
 \&
-		woke = my_futex_waitv(waiters, countof(futexes), 0, &timeout, CLOCK_MONOTONIC);
+		woke = my_futex_waitv(waiters, countof(futexes), 0,
+		                      &timeout, CLOCK_MONOTONIC);
 		if (woke == \-1 && (errno != EAGAIN && errno != EWOULDBLOCK))
 			err(EXIT_FAILURE, "my_futex_waitv");
 \&
diff --git a/man/man4/console_codes.4 b/man/man4/console_codes.4
index faf12a66c..8ce182fad 100644
--- a/man/man4/console_codes.4
+++ b/man/man4/console_codes.4
@@ -755,13 +755,23 @@ ESC ] 1 ; \f[I]txt\f[] ST	Set icon name to \f[I]txt\f[].
 ESC ] 2 ; \f[I]txt\f[] ST	Set window title to \f[I]txt\f[].
 ESC ] 4 ; \f[I]num\f[] ; \f[I]txt\f[] ST	Set color \f[I]num\f[] (0-255) to \f[I]txt\f[].
 ESC ] 5 ; 0 ; \f[I]txt\f[] ST	Set the color for bold substitution to \f[I]txt\f[].
-ESC ] 5 ; 1 ; \f[I]txt\f[] ST	Set the color for underline substitution to \f[I]txt\f[].
-ESC ] 5 ; 2 ; \f[I]txt\f[] ST	Set the color for blinking substitution to \f[I]txt\f[].
+ESC ] 5 ; 1 ; \f[I]txt\f[] ST	T{
+Set the color for underline substitution to \f[I]txt\f[].
+T}
+ESC ] 5 ; 2 ; \f[I]txt\f[] ST	T{
+Set the color for blinking substitution to \f[I]txt\f[].
+T}
 ESC ] 5 ; 3 ; \f[I]txt\f[] ST	Set the color for reverse substitution to \f[I]txt\f[].
 ESC ] 5 ; 4 ; \f[I]txt\f[] ST	Set the color for italic substitution to \f[I]txt\f[].
-ESC ] 6 ; 0 ; \f[I]val\f[] ST	Toggle bold rendition: 0=bold, 1=substitute by color.
-ESC ] 6 ; 1 ; \f[I]val\f[] ST	Toggle underscore rendition: 0=underscore, 1=color.
-ESC ] 6 ; 2 ; \f[I]val\f[] ST	Toggle blinking rendition: 0=blinking, 1=color.
+ESC ] 6 ; 0 ; \f[I]val\f[] ST	T{
+Toggle bold rendition: 0=bold, 1=substitute by color.
+T}
+ESC ] 6 ; 1 ; \f[I]val\f[] ST	T{
+Toggle underscore rendition: 0=underscore, 1=color.
+T}
+ESC ] 6 ; 2 ; \f[I]val\f[] ST	T{
+Toggle blinking rendition: 0=blinking, 1=color.
+T}
 ESC ] 6 ; 3 ; \f[I]val\f[] ST	Toggle reverse rendition: 0=reverse, 1=color.
 ESC ] 6 ; 4 ; \f[I]val\f[] ST	Toggle italic rendition: 0=italic, 1=color.
 ESC ] 10 ; \f[I]txt\f[] ST	Set the foreground text color to \f[I]txt\f[].
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-10-19 22:41 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-17 19:19 `make -R check` fails due to futex_waitv.2 and console_codes.4 being too wide Hugo Buddelmeijer
2026-10-19  6:20 ` Alejandro Colomar
2026-10-19 13:02   ` table layout in console_codes.4 (was: `make -R check` fails due to futex_waitv.2 and console_codes.4 being too wide) G. Branden Robinson
2026-10-19 16:55     ` Alejandro Colomar
2026-10-19 18:32     ` table layout in console_codes.4 Hugo Buddelmeijer
2026-10-19 22:41       ` table layout in console_codes.4 (was: `make -R check` fails due to futex_waitv.2 and console_codes.4 being too wide) G. Branden Robinson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.