From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Fiona Klute <fiona.klute@gmx.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support
Date: Mon, 19 Oct 2026 19:25:44 +0200 [thread overview]
Message-ID: <atZRLNEv27mHGuZP@windsurf> (raw)
In-Reply-To: <20261018232916.3896517-1-fiona.klute@gmx.de>
On Mon, Oct 19, 2026 at 01:29:15AM +0200, Fiona Klute via buildroot wrote:
> Commit d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools:
> fix target FIT signature support") changed how options for FIT support
> are written to include/generated/autoconf.h, removing the
> unconditional "echo" call (possibly with empty arguments) that existed
> before. Because of this, include/generated/autoconf.h was not created
> when U-Boot was built without FIT support, making the build fail
> because of the missing header. Add a "touch" to ensure the file is
> always created.
>
> Fixes: d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools: fix target FIT signature support")
>
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
Applied to master, thanks!
Just reviewing the previous change:
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_RSASSA_PSS 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000' >> $(@D)/include/generated/autoconf.h)
Seems a bit heavy. What about:
$(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT), \
(echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' ; \
echo '#define CONFIG_TOOLS_RSASSA_PSS 1' ; \
echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' ; \
echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000') >> \
$(@D)/include/generated/autoconf.h \
)
Something along those lines?
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2026-10-19 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-18 23:29 [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support Fiona Klute via buildroot
2026-10-19 17:25 ` Thomas Petazzoni via buildroot [this message]
2026-10-19 20:07 ` Fiona Klute via buildroot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atZRLNEv27mHGuZP@windsurf \
--to=buildroot@buildroot.org \
--cc=fiona.klute@gmx.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.