* [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support
@ 2026-10-18 23:29 Fiona Klute via buildroot
2026-10-19 17:25 ` Thomas Petazzoni via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Fiona Klute via buildroot @ 2026-10-18 23:29 UTC (permalink / raw)
To: buildroot; +Cc: Fiona Klute
Commit d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools:
fix target FIT signature support") changed how options for FIT support
are written to include/generated/autoconf.h, removing the
unconditional "echo" call (possibly with empty arguments) that existed
before. Because of this, include/generated/autoconf.h was not created
when U-Boot was built without FIT support, making the build fail
because of the missing header. Add a "touch" to ensure the file is
always created.
Fixes: d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools: fix target FIT signature support")
Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
---
package/uboot-tools/uboot-tools.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/uboot-tools/uboot-tools.mk b/package/uboot-tools/uboot-tools.mk
index 32fe9f1d7b..87b708ac5c 100644
--- a/package/uboot-tools/uboot-tools.mk
+++ b/package/uboot-tools/uboot-tools.mk
@@ -31,6 +31,7 @@ define UBOOT_TOOLS_CONFIGURE_CMDS
echo "#include <linux/kconfig.h>" > $(@D)/include/config.h
touch $(@D)/include/config/auto.conf
mkdir -p $(@D)/include/generated
+ touch $(@D)/include/generated/autoconf.h
$(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT),$(UBOOT_TOOLS_ENABLE_HASH_ALGOS))
$(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SUPPORT),echo '#define CONFIG_TOOLS_FIT_PRINT 1' >> $(@D)/include/generated/autoconf.h)
$(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' >> $(@D)/include/generated/autoconf.h)
--
2.55.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support
2026-10-18 23:29 [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support Fiona Klute via buildroot
@ 2026-10-19 17:25 ` Thomas Petazzoni via buildroot
2026-10-19 20:07 ` Fiona Klute via buildroot
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-19 17:25 UTC (permalink / raw)
To: Fiona Klute; +Cc: buildroot
On Mon, Oct 19, 2026 at 01:29:15AM +0200, Fiona Klute via buildroot wrote:
> Commit d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools:
> fix target FIT signature support") changed how options for FIT support
> are written to include/generated/autoconf.h, removing the
> unconditional "echo" call (possibly with empty arguments) that existed
> before. Because of this, include/generated/autoconf.h was not created
> when U-Boot was built without FIT support, making the build fail
> because of the missing header. Add a "touch" to ensure the file is
> always created.
>
> Fixes: d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools: fix target FIT signature support")
>
> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
Applied to master, thanks!
Just reviewing the previous change:
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_RSASSA_PSS 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' >> $(@D)/include/generated/autoconf.h)
+ $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000' >> $(@D)/include/generated/autoconf.h)
Seems a bit heavy. What about:
$(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT), \
(echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' ; \
echo '#define CONFIG_TOOLS_RSASSA_PSS 1' ; \
echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' ; \
echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000') >> \
$(@D)/include/generated/autoconf.h \
)
Something along those lines?
Best regards,
Thomas Petazzoni
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support
2026-10-19 17:25 ` Thomas Petazzoni via buildroot
@ 2026-10-19 20:07 ` Fiona Klute via buildroot
0 siblings, 0 replies; 3+ messages in thread
From: Fiona Klute via buildroot @ 2026-10-19 20:07 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: buildroot
Am 19.10.26 um 19:25 schrieb Thomas Petazzoni:
> On Mon, Oct 19, 2026 at 01:29:15AM +0200, Fiona Klute via buildroot wrote:
>> Commit d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools:
>> fix target FIT signature support") changed how options for FIT support
>> are written to include/generated/autoconf.h, removing the
>> unconditional "echo" call (possibly with empty arguments) that existed
>> before. Because of this, include/generated/autoconf.h was not created
>> when U-Boot was built without FIT support, making the build fail
>> because of the missing header. Add a "touch" to ensure the file is
>> always created.
>>
>> Fixes: d7ccf54d7f8cfcb1ab40b227c080aee36f5a6aa1 ("package/uboot-tools: fix target FIT signature support")
>>
>> Signed-off-by: Fiona Klute <fiona.klute@gmx.de>
>
> Applied to master, thanks!
>
> Just reviewing the previous change:
>
> + $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' >> $(@D)/include/generated/autoconf.h)
> + $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_RSASSA_PSS 1' >> $(@D)/include/generated/autoconf.h)
> + $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' >> $(@D)/include/generated/autoconf.h)
> + $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT),echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000' >> $(@D)/include/generated/autoconf.h)
>
> Seems a bit heavy. What about:
>
> $(if $(BR2_PACKAGE_UBOOT_TOOLS_FIT_SIGNATURE_SUPPORT), \
> (echo '#define CONFIG_TOOLS_IMAGE_PRE_LOAD 1' ; \
> echo '#define CONFIG_TOOLS_RSASSA_PSS 1' ; \
> echo '#define CONFIG_TOOLS_FIT_SIGNATURE 1' ; \
> echo '#define CONFIG_TOOLS_FIT_SIGNATURE_MAX_SIZE 0x10000000') >> \
> $(@D)/include/generated/autoconf.h \
> )
>
> Something along those lines?
Seems reasonable to me, and maybe make it a snippet shared between host
and target, like UBOOT_TOOLS_ENABLE_HASH_ALGOS.
There's also the option to use kconfig, but that's a big can of worms.
Best regards,
Fiona
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-19 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-18 23:29 [Buildroot] [PATCH 1/1] package/uboot-tools: fix build without FIT support Fiona Klute via buildroot
2026-10-19 17:25 ` Thomas Petazzoni via buildroot
2026-10-19 20:07 ` Fiona Klute via buildroot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.