From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Jiaxing Hu <gahing@gahingwoo.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: rockchip: let TCPM own the USB-C VBUS on CM5-IO
Date: Tue, 27 Oct 2026 01:53:27 +0100 [thread overview]
Message-ID: <at_1n-ujVQIPUsMT@venus> (raw)
In-Reply-To: <20261024083942.148860-1-gahing@gahingwoo.com>
[-- Attachment #1: Type: text/plain, Size: 1301 bytes --]
Hi,
On Sat, Oct 24, 2026 at 09:39:42PM +1300, Jiaxing Hu wrote:
> vcc_5v0_typec0 is the switched VBUS of the USB-C port. It is the
> vbus-supply of the FUSB302, but also the phy-supply of u2phy0_otg.
> The PHY enables it at boot and keeps it on, so TCPM never sees
> vSafe0V and a sink partner stays in SRC_ATTACH_WAIT. A USB-C dock is
> not detected.
>
> Drop the phy-supply and leave VBUS to TCPM.
>
> Fixes: 44a48a23974b ("arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiaxing Hu <gahing@gahingwoo.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Greetings,
-- Sebastian
> Resent with the lists on Cc. The first copy went to Heiko only.
>
> arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> index 5958b391e..72ca49ec3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> @@ -306,7 +306,6 @@ &u2phy0 {
> };
>
> &u2phy0_otg {
> - phy-supply = <&vcc_5v0_typec0>;
> status = "okay";
> };
>
> --
> 2.43.0
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Jiaxing Hu <gahing@gahingwoo.com>
Cc: Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] arm64: dts: rockchip: let TCPM own the USB-C VBUS on CM5-IO
Date: Tue, 27 Oct 2026 01:53:27 +0100 [thread overview]
Message-ID: <at_1n-ujVQIPUsMT@venus> (raw)
In-Reply-To: <20261024083942.148860-1-gahing@gahingwoo.com>
[-- Attachment #1.1: Type: text/plain, Size: 1301 bytes --]
Hi,
On Sat, Oct 24, 2026 at 09:39:42PM +1300, Jiaxing Hu wrote:
> vcc_5v0_typec0 is the switched VBUS of the USB-C port. It is the
> vbus-supply of the FUSB302, but also the phy-supply of u2phy0_otg.
> The PHY enables it at boot and keeps it on, so TCPM never sees
> vSafe0V and a sink partner stays in SRC_ATTACH_WAIT. A USB-C dock is
> not detected.
>
> Drop the phy-supply and leave VBUS to TCPM.
>
> Fixes: 44a48a23974b ("arm64: dts: rockchip: Add ArmSoM CM5 and CM5-IO")
> Cc: stable@vger.kernel.org
> Signed-off-by: Jiaxing Hu <gahing@gahingwoo.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Greetings,
-- Sebastian
> Resent with the lists on Cc. The first copy went to Heiko only.
>
> arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> index 5958b391e..72ca49ec3 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-armsom-cm5-io.dts
> @@ -306,7 +306,6 @@ &u2phy0 {
> };
>
> &u2phy0_otg {
> - phy-supply = <&vcc_5v0_typec0>;
> status = "okay";
> };
>
> --
> 2.43.0
>
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 170 bytes --]
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-10-27 0:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-24 8:39 [PATCH RESEND] arm64: dts: rockchip: let TCPM own the USB-C VBUS on CM5-IO Jiaxing Hu
2026-10-24 8:39 ` Jiaxing Hu
2026-10-27 0:53 ` Sebastian Reichel [this message]
2026-10-27 0:53 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=at_1n-ujVQIPUsMT@venus \
--to=sebastian.reichel@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gahing@gahingwoo.com \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.