All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support
@ 2026-10-20 13:53 Yegor Yefremov
  2026-10-20 14:04 ` Thomas Petazzoni via buildroot
  2026-10-20 14:38 ` Joachim Wiberg
  0 siblings, 2 replies; 3+ messages in thread
From: Yegor Yefremov @ 2026-10-20 13:53 UTC (permalink / raw)
  To: buildroot; +Cc: Joachim Wiberg

Since version 4.2, mg uses iswalnum() from <wctype.h> to tell whether
a UTF-8 character is part of a word (upstream commit ee22ef729b16
"Tell UTF-8 words by their Unicode class"). This breaks the build with
toolchains that lack wide character support, such as uClibc without
WCHAR:

utf8.c:23:10: fatal error: wctype.h: No such file or directory
   23 | #include <wctype.h>
      |          ^~~~~~~~~~

Add a dependency on BR2_USE_WCHAR, together with the matching comment.

This issue has been present since commit 3b5fbe8f6e78 ("package/mg:
bump to v4.4"), which updated mg from 4.1, so it pulled in this
change. That commit is not part of any release nor of any maintenance
branch yet, so only master is affected.

Fixes:
https://autobuild.buildroot.org/results/9d55c1b27627118c4279d9aade9f65b45db57e52

Fixes: 3b5fbe8f6e7869c41616bb7e1e97b20f52f9976a ("package/mg: bump to v4.4")
Assisted-by: Claude:claude-opus-5-5
Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 package/mg/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/mg/Config.in b/package/mg/Config.in
index 35e0e6f57f..7eb052d1a8 100644
--- a/package/mg/Config.in
+++ b/package/mg/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_MG
 	bool "mg"
 	depends on BR2_USE_MMU # fork()
+	depends on BR2_USE_WCHAR
 	help
 	  Emacs-like text editor (260 kiB)
 
@@ -16,3 +17,7 @@ config BR2_PACKAGE_MG
 	  and, in particular, no requirement on ncurses or termcap.
 
 	  https://github.com/troglobit/mg/
+
+comment "mg needs a toolchain w/ wchar"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support
  2026-10-20 13:53 [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support Yegor Yefremov
@ 2026-10-20 14:04 ` Thomas Petazzoni via buildroot
  2026-10-20 14:38 ` Joachim Wiberg
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni via buildroot @ 2026-10-20 14:04 UTC (permalink / raw)
  To: Yegor Yefremov; +Cc: buildroot, Joachim Wiberg

On Tue, Oct 20, 2026 at 03:53:00PM +0200, Yegor Yefremov wrote:
> Since version 4.2, mg uses iswalnum() from <wctype.h> to tell whether
> a UTF-8 character is part of a word (upstream commit ee22ef729b16
> "Tell UTF-8 words by their Unicode class"). This breaks the build with
> toolchains that lack wide character support, such as uClibc without
> WCHAR:
> 
> utf8.c:23:10: fatal error: wctype.h: No such file or directory
>    23 | #include <wctype.h>
>       |          ^~~~~~~~~~
> 
> Add a dependency on BR2_USE_WCHAR, together with the matching comment.
> 
> This issue has been present since commit 3b5fbe8f6e78 ("package/mg:
> bump to v4.4"), which updated mg from 4.1, so it pulled in this
> change. That commit is not part of any release nor of any maintenance
> branch yet, so only master is affected.
> 
> Fixes:
> https://autobuild.buildroot.org/results/9d55c1b27627118c4279d9aade9f65b45db57e52
> 
> Fixes: 3b5fbe8f6e7869c41616bb7e1e97b20f52f9976a ("package/mg: bump to v4.4")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>

Applied to master, thanks!

Best regards,

Thomas Petazzoni
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support
  2026-10-20 13:53 [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support Yegor Yefremov
  2026-10-20 14:04 ` Thomas Petazzoni via buildroot
@ 2026-10-20 14:38 ` Joachim Wiberg
  1 sibling, 0 replies; 3+ messages in thread
From: Joachim Wiberg @ 2026-10-20 14:38 UTC (permalink / raw)
  To: Yegor Yefremov, buildroot


[-- Attachment #1.1: Type: text/plain, Size: 752 bytes --]

On Tue, 2026-10-20 at 15:53 +0200, Yegor Yefremov wrote:
> Since version 4.2, mg uses iswalnum() from <wctype.h> to tell whether
> a UTF-8 character is part of a word (upstream commit ee22ef729b16
> "Tell UTF-8 words by their Unicode class"). This breaks the build with
> toolchains that lack wide character support, such as uClibc without
> WCHAR:
> 
> utf8.c:23:10: fatal error: wctype.h: No such file or directory
>    23 | #include <wctype.h>
>       |          ^~~~~~~~~~
> 
> Add a dependency on BR2_USE_WCHAR, together with the matching comment.

Thank you Yegor, my bad!

I'll upstream a configure check for wctype.h so we can drop this
restriction in Buildroot in a future update.

Best regards
 /Joachim


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-20 14:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-20 13:53 [Buildroot] [PATCH] package/mg: needs a toolchain with wchar support Yegor Yefremov
2026-10-20 14:04 ` Thomas Petazzoni via buildroot
2026-10-20 14:38 ` Joachim Wiberg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.