From: "Uwe Kleine-König" <ukleinek@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Alexander Patrakov <patrakov@gmail.com>,
johannes.goede@oss.qualcomm.com, adee.sahan@gmail.com,
andy@kernel.org, antti.laakso@linux.intel.com,
dan.scally@ideasonboard.com, diamondback@cohunt.app,
ilpo.jarvinen@linux.intel.com, linux-media@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 3/3] media: i2c: ov5675: Add the OVTI5678 RGB-IR variant
Date: Tue, 20 Oct 2026 14:13:18 +0200 [thread overview]
Message-ID: <atdaMqiA3RSb5GEs@monoceros> (raw)
In-Reply-To: <atcs_nK50gJ3dBRX@ashevche-desk.local>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hello Andy,
On Tue, Oct 20, 2026 at 11:57:34AM +0300, Andy Shevchenko wrote:
> On Tue, Oct 20, 2026 at 11:42:07AM +0300, Sakari Ailus wrote:
> > On Tue, Oct 20, 2026 at 09:50:01AM +0800, Alexander Patrakov wrote:
>
> ...
>
> > > #include <linux/gpio/consumer.h>
> > > #include <linux/i2c.h>
> > > +#include <linux/mod_devicetable.h>
> >
> > #include <linux/device-id/acpi.h>
>
> No, this has to be part of i2c.h on par with device-id/of.h
Well, <linux/i2c.h> includes <linux/acpi.h> which in turn includes
<linux/device-id/acpi.h>, so <linux/i2c.h> already provides
acpi_device_id.
> Uwe, can we get this fixed, please?
With the above said, there is nothing to fix, is there?
Best regards
Uwe
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-10-20 12:13 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 14:17 [PATCH 0/5] platform/x86: int3472: Fix AVDD and add DOVDD + DVDD mappings Hans de Goede
2026-10-16 14:17 ` [PATCH 1/5] media: ov05c10: Support full range of power rails Hans de Goede
2026-10-17 7:20 ` Andy Shevchenko
2026-10-19 10:27 ` Dan Scally
2026-10-16 14:17 ` [PATCH 2/5] platform/x86: int3472: Rename DOVDD GPIO type to AVDD Hans de Goede
2026-10-19 7:32 ` Andy Shevchenko
2026-10-19 10:54 ` Dan Scally
2026-10-16 14:17 ` [PATCH 3/5] platform/x86: int3472: Add support for DOVDD and DVDD GPIO types Hans de Goede
2026-10-19 9:01 ` Andy Shevchenko
2026-10-19 11:02 ` Dan Scally
2026-10-16 14:17 ` [PATCH 4/5] platform/x86: int3472: Rename avdd_second_sensor to power_enable_second_sensor Hans de Goede
2026-10-19 10:52 ` Andy Shevchenko
2026-10-19 10:54 ` Dan Scally
2026-10-16 14:17 ` [PATCH 5/5] platform/x86: int3472: Properly map the AVDD GPIO type to a "avdd" regulator Hans de Goede
2026-10-19 11:01 ` Andy Shevchenko
2026-10-19 11:02 ` Dan Scally
2026-10-20 1:41 ` [PATCH 0/5] platform/x86: int3472: Fix AVDD and add DOVDD + DVDD mappings Alexander Patrakov
2026-10-20 1:49 ` [PATCH 1/3] media: ipu-bridge: Add sensor configuration for OV5675 (OVTI5678) Alexander Patrakov
2026-10-20 1:50 ` [PATCH 2/3] media: i2c: ov5675: Defer the probe until the endpoint exists Alexander Patrakov
2026-10-20 6:34 ` Andy Shevchenko
2026-10-20 8:39 ` Sakari Ailus
2026-10-20 1:50 ` [PATCH 3/3] media: i2c: ov5675: Add the OVTI5678 RGB-IR variant Alexander Patrakov
2026-10-20 6:42 ` Andy Shevchenko
2026-10-20 6:46 ` Alexander Patrakov
2026-10-20 8:42 ` Sakari Ailus
2026-10-20 8:57 ` Andy Shevchenko
2026-10-20 12:13 ` Uwe Kleine-König [this message]
2026-10-20 6:07 ` [PATCH 1/3] media: ipu-bridge: Add sensor configuration for OV5675 (OVTI5678) Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atdaMqiA3RSb5GEs@monoceros \
--to=ukleinek@kernel.org \
--cc=adee.sahan@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antti.laakso@linux.intel.com \
--cc=dan.scally@ideasonboard.com \
--cc=diamondback@cohunt.app \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johannes.goede@oss.qualcomm.com \
--cc=linux-media@vger.kernel.org \
--cc=patrakov@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.