All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header
Date: Wed, 21 Oct 2026 09:46:48 +0200	[thread overview]
Message-ID: <atht6OHisTqDHk0u@lore-desk> (raw)
In-Reply-To: <20261020222909.1937894-1-pablo@netfilter.org>

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

> Use skb_pull_rcsum() to pop the IPIP and IP6IP6 tunnel header so this
> works with CHECKSUM_COMPLETE.
> 
> Fixes: ab427db17885 ("netfilter: flowtable: Add IPIP rx sw acceleration")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> ---
>  net/netfilter/nf_flow_table_ip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
> index bb894c4f2b4a..f9b6119c9db5 100644
> --- a/net/netfilter/nf_flow_table_ip.c
> +++ b/net/netfilter/nf_flow_table_ip.c
> @@ -370,7 +370,7 @@ static void nf_flow_ip_tunnel_pop(struct nf_flowtable_ctx *ctx,
>  	    ctx->tun.inner_proto != IPPROTO_IPV6)
>  		return;
>  
> -	skb_pull(skb, ctx->tun.hdr_size);
> +	skb_pull_rcsum(skb, ctx->tun.hdr_size);
>  	skb_reset_network_header(skb);
>  }
>  
> -- 
> 2.47.3
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2026-10-21  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-20 22:29 [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header Pablo Neira Ayuso
2026-10-21  7:46 ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atht6OHisTqDHk0u@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.