All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header
@ 2026-10-20 22:29 Pablo Neira Ayuso
  2026-10-21  7:46 ` Lorenzo Bianconi
  0 siblings, 1 reply; 2+ messages in thread
From: Pablo Neira Ayuso @ 2026-10-20 22:29 UTC (permalink / raw)
  To: netfilter-devel; +Cc: lorenzo

Use skb_pull_rcsum() to pop the IPIP and IP6IP6 tunnel header so this
works with CHECKSUM_COMPLETE.

Fixes: ab427db17885 ("netfilter: flowtable: Add IPIP rx sw acceleration")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
 net/netfilter/nf_flow_table_ip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
index bb894c4f2b4a..f9b6119c9db5 100644
--- a/net/netfilter/nf_flow_table_ip.c
+++ b/net/netfilter/nf_flow_table_ip.c
@@ -370,7 +370,7 @@ static void nf_flow_ip_tunnel_pop(struct nf_flowtable_ctx *ctx,
 	    ctx->tun.inner_proto != IPPROTO_IPV6)
 		return;
 
-	skb_pull(skb, ctx->tun.hdr_size);
+	skb_pull_rcsum(skb, ctx->tun.hdr_size);
 	skb_reset_network_header(skb);
 }
 
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header
  2026-10-20 22:29 [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header Pablo Neira Ayuso
@ 2026-10-21  7:46 ` Lorenzo Bianconi
  0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2026-10-21  7:46 UTC (permalink / raw)
  To: Pablo Neira Ayuso; +Cc: netfilter-devel

[-- Attachment #1: Type: text/plain, Size: 919 bytes --]

> Use skb_pull_rcsum() to pop the IPIP and IP6IP6 tunnel header so this
> works with CHECKSUM_COMPLETE.
> 
> Fixes: ab427db17885 ("netfilter: flowtable: Add IPIP rx sw acceleration")
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>

> ---
>  net/netfilter/nf_flow_table_ip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/nf_flow_table_ip.c b/net/netfilter/nf_flow_table_ip.c
> index bb894c4f2b4a..f9b6119c9db5 100644
> --- a/net/netfilter/nf_flow_table_ip.c
> +++ b/net/netfilter/nf_flow_table_ip.c
> @@ -370,7 +370,7 @@ static void nf_flow_ip_tunnel_pop(struct nf_flowtable_ctx *ctx,
>  	    ctx->tun.inner_proto != IPPROTO_IPV6)
>  		return;
>  
> -	skb_pull(skb, ctx->tun.hdr_size);
> +	skb_pull_rcsum(skb, ctx->tun.hdr_size);
>  	skb_reset_network_header(skb);
>  }
>  
> -- 
> 2.47.3
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-10-21  7:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-20 22:29 [PATCH nf] netfilter: flowtable: use skb_pull_rcsum() to pull IPIP tunnel header Pablo Neira Ayuso
2026-10-21  7:46 ` Lorenzo Bianconi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.