All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-block@nongnu.org,  Hanna Reitz <hreitz@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH v2] block: Print simple help text when calling "-blockdev help"
Date: Wed, 21 Oct 2026 08:36:55 -0500	[thread overview]
Message-ID: <ati_uGk-toJTHMmo@redhat.com> (raw)
In-Reply-To: <ati-ypnuwK73MPDF@redhat.com>

On Wed, Oct 21, 2026 at 08:34:20AM -0500, Eric Blake wrote:
> On Mon, Sep 14, 2026 at 11:00:36AM +0200, Thomas Huth wrote:
> > Other command line options like "-chardev", "-netdev" or "-device"
> > already present the user with a list of available parameters, but
> > when running "-blockdev help", there is currently only an error
> > message. There is already the possibility to run "-drive format=help",
> > but it does not seem to be documented, so this is not very useful
> > for the average user. Thus let's improve this situation by providing
> > a proper list of available drivers when running QEMU with
> > "-blockdev help".
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  v2: Don't re-use the code from "-drive format=help" and print the
> >      help in a better readable way instead
> 
> One format per line rather than space-separated does seem a bit more
> machine-parseable, although the output no longer fits in my preferred
> terminal size without scrolling. I guess "more readable" is subjective
> ;)

That said, we aren't very consistent; "-chardev help" indents each
line by two, while "-netdev help" and this patch for "-blockdev help"
does not indent.  May be worth a followup patch.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization:  qemu.org | libguestfs.org



  reply	other threads:[~2026-10-21 13:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14  9:00 [PATCH v2] block: Print simple help text when calling "-blockdev help" Thomas Huth
2026-10-20 13:58 ` Thomas Huth
2026-10-21 13:34 ` Eric Blake
2026-10-21 13:36   ` Eric Blake [this message]
2026-10-30 10:38 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ati_uGk-toJTHMmo@redhat.com \
    --to=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.