From: Mark Brown <broonie@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Theodore Tso <tytso@mit.edu>,
Shuah Khan <skhan@linuxfoundation.org>,
Bart Van Assche <bvanassche@acm.org>,
johannes.goede@oss.qualcomm.com, Jiri Kosina <jikos@kernel.org>,
ksummit@lists.linux.dev, sashiko@lists.linux.dev
Subject: Re: Patch pre-submission to Sashiko
Date: Thu, 22 Oct 2026 13:05:25 +0100 [thread overview]
Message-ID: <atn8Bcgvj9RGGTL3@sirena.co.uk> (raw)
In-Reply-To: <20261021114524.4c2ea2a31a9d527b78e78768@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
On Wed, Oct 21, 2026 at 11:45:24AM -0700, Andrew Morton wrote:
> If someone's fixing something I don't see much value in
> retaining/maintaining a test case for something we've already fixed.
> This is considered good engineering practice but why bother - we fixed
> it! Move on.
Like others have said there's a bunch of people would say the opposite.
In the particular case I referenced where the code is generally pretty
fragile (we have rather a lot of paths through that code) and we want to
do a bunch of refactoring in the area it seems especially useful to keep
the coverage. It's far too likely that someone could make a mistake in
this area, and quite likely that someone would want to do relevant work.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-10-22 12:05 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 17:28 Patch pre-submission to Sashiko Jiri Kosina
2026-10-17 18:02 ` Theodore Tso
2026-10-19 11:02 ` johannes.goede
2026-10-19 20:27 ` Theodore Tso
2026-10-20 14:20 ` Bart Van Assche
2026-10-20 19:21 ` Theodore Tso
2026-10-20 20:15 ` Miguel Ojeda
2026-10-20 20:43 ` Shuah Khan
2026-10-21 11:07 ` Mark Brown
2026-10-21 16:20 ` Theodore Tso
2026-10-21 16:33 ` Mark Brown
2026-10-21 18:45 ` Andrew Morton
2026-10-21 19:15 ` Rafael J. Wysocki (Intel)
2026-10-21 19:56 ` Theodore Tso
2026-10-22 11:44 ` Miguel Ojeda
2026-10-21 20:10 ` Jiri Kosina
2026-10-21 20:24 ` Steven Rostedt
2026-10-21 20:46 ` Paul E. McKenney
2026-10-22 6:15 ` Dan Carpenter
2026-10-22 12:05 ` Mark Brown [this message]
2026-10-22 12:37 ` Rafael J. Wysocki (Intel)
2026-10-22 14:45 ` Liam R. Howlett
2026-10-17 18:20 ` Alexei Starovoitov
2026-10-17 18:38 ` Arnaldo Melo
2026-10-19 7:02 ` Dan Carpenter
2026-10-18 11:46 ` Mark Brown
2026-10-17 18:20 ` Linus Torvalds
2026-10-17 20:10 ` Roman Gushchin
2026-10-18 13:41 ` Steven Rostedt
2026-10-18 18:41 ` Kees Cook
2026-10-18 18:58 ` Linus Torvalds
2026-10-19 5:55 ` Oliver Slapinski
2026-10-17 19:42 ` Andrew Lunn
2026-10-18 11:54 ` Mark Brown
2026-10-18 16:48 ` Laurent Pinchart
2026-10-19 6:25 ` Krzysztof Kozlowski
2026-10-19 7:26 ` David Woodhouse
2026-10-19 11:40 ` Michal Simek
2026-10-19 12:02 ` Julia Lawall
2026-10-19 12:46 ` Michal Simek
2026-10-19 12:57 ` Julia Lawall
2026-10-19 17:30 ` Rodrigo Vivi
2026-10-19 17:53 ` Shuah Khan
2026-10-19 18:17 ` Arnaldo Melo
2026-10-19 20:35 ` Theodore Tso
2026-10-20 2:28 ` Chen-Yu Tsai
2026-10-20 8:36 ` Jiri Kosina
2026-10-20 8:48 ` Vlastimil Babka (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=atn8Bcgvj9RGGTL3@sirena.co.uk \
--to=broonie@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bvanassche@acm.org \
--cc=jikos@kernel.org \
--cc=johannes.goede@oss.qualcomm.com \
--cc=ksummit@lists.linux.dev \
--cc=sashiko@lists.linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.