Re: [PATCH v2 4/4] arm64: dts: qcom: Use DP AltMode defines

From: Bjorn Andersson <andersson@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	Heiko Stuebner <heiko@sntech.de>,
	 Matthias Brugger <matthias.bgg@gmail.com>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Konrad Dybcio <konradybcio@kernel.org>,
	 linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org,
	 linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, kernel@collabora.com,
	 Sebastian Reichel <sebastian.reichel@collabora.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: Use DP AltMode defines
Date: Sat, 7 Nov 2026 16:42:19 -0600	[thread overview]
Message-ID: <au-pMBoYrUn89Zhy@zenbook> (raw)
In-Reply-To: <20261017-dp-altmode-dt-defines-v2-4-7ab3d93553dd@collabora.com>

On Sat, Oct 17, 2026 at 09:59:33PM +0200, Sebastian Reichel wrote:
> From: Sebastian Reichel <sebastian.reichel@collabora.com>
> 
> Use the new USB-C DP AltMode defines for the SVID and the capabilities
> VDO to make the DTs more readable.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Acked-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
>  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 8 ++++++--
>  arch/arm64/boot/dts/qcom/sm8150-hdk.dts  | 9 +++++++--
>  2 files changed, 13 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index d6af679abe1a..d21b94e872ce 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1508,8 +1508,12 @@ PDO_FIXED_USB_COMM |
>  
>  		altmodes {
>  			displayport {
> -				svid = /bits/ 16 <0xff01>;
> -				vdo = <0x00001c46>;
> +				svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
> +				vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
> +					      DP_CAP_UHBR_13_5_UNSUPPORTED,
> +					      DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
> +					      DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
> +					      DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
>  			};
>  		};
>  
> diff --git a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> index cdced5c848d3..3d83dd305954 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8150-hdk.dts
> @@ -581,8 +581,13 @@ PDO_FIXED_USB_COMM |
>  
>  		altmodes {
>  			displayport {
> -				svid = /bits/ 16 <0xff01>;
> -				vdo = <0x00001c46>;
> +				svid = /bits/ 16 <USB_SVID_DP_ALTMODE>;
> +				vdo = <VDO_DP(DP_CAP_DPAM_V2_0, DP_CAP_CABLE_TYPE_PASSIVE,
> +					      DP_CAP_UHBR_13_5_UNSUPPORTED,
> +					      DP_PIN_UFP_NONE, DP_PIN_DFP_C_D_E,
> +					      DP_CAP_USB2_USED, DP_CAP_RECEPTACLE,
> +					      DP_CAP_SIGNALLING_HBR3, DP_CAP_DFP_D)>;
> +
>  			};
>  		};
>  
> 
> -- 
> 2.53.0
> 

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip