Re: [PATCH v1 03/28] x86/hvm: report SVM x2AVIC support

[dmukhin@ford.com]

On Thu, Nov 05, 2026 at 05:13:50PM -0500, Jason Andryuk wrote:
> On 2026-11-04 20:33, dmukhin@ford.com wrote:
> > From: Denis Mukhin <dmukhin@ford.com>
> > 
> > Report SVM AVIC support from CPUID Fn8000000A_EDX[X2AVIC](bit 18).
> > 
> > Signed-off-by: Denis Mukhin <dmukhin@ford.com>
> > ---
> >   xen/arch/x86/hvm/svm/svm.c         | 1 +
> >   xen/arch/x86/include/asm/hvm/svm.h | 2 ++
> >   2 files changed, 3 insertions(+)
> > 
> > diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> > index cf008a8acdf2..db81dad4b681 100644
> > --- a/xen/arch/x86/hvm/svm/svm.c
> > +++ b/xen/arch/x86/hvm/svm/svm.c
> > @@ -2457,6 +2457,7 @@ static void __init print_svm_features(void)
> >       P(cpu_has_svm_vnmi, "Virtual NMI");
> >       P(cpu_has_svm_bus_lock, "Bus Lock Filter");
> >       P(cpu_has_svm_avic, "Advanced Virtual Interrupt Controller");
> > +    P(cpu_has_svm_x2avic, "x2 Advanced Virtual Interrupt Controller");
> 
> Sorry, this ...
> 
> >   #undef P
> >       if ( !printed )
> > diff --git a/xen/arch/x86/include/asm/hvm/svm.h b/xen/arch/x86/include/asm/hvm/svm.h
> > index 0fc33f41b09d..292a9ee19b11 100644
> > --- a/xen/arch/x86/include/asm/hvm/svm.h
> > +++ b/xen/arch/x86/include/asm/hvm/svm.h
> > @@ -36,6 +36,7 @@ extern u32 svm_feature_flags;
> >   #define SVM_FEATURE_AVIC          13 /* Advanced Virtual Interrupt Controller */
> >   #define SVM_FEATURE_VLOADSAVE     15 /* virtual vmload/vmsave */
> >   #define SVM_FEATURE_VGIF          16 /* Virtual GIF */
> > +#define SVM_FEATURE_X2AVIC        18 /* x2 Advanced Virtual Interrupt Controller */
> >   #define SVM_FEATURE_SSS           19 /* NPT Supervisor Shadow Stacks */
> >   #define SVM_FEATURE_SPEC_CTRL     20 /* MSR_SPEC_CTRL virtualisation */
> >   #define SVM_FEATURE_VNMI          25 /* Virtual NMI */
> > @@ -57,6 +58,7 @@ static inline bool cpu_has_svm_feature(unsigned int feat)
> >   #define cpu_has_pause_thresh  cpu_has_svm_feature(SVM_FEATURE_PAUSETHRESH)
> >   #define cpu_has_tsc_ratio     cpu_has_svm_feature(SVM_FEATURE_TSCRATEMSR)
> >   #define cpu_has_svm_avic      cpu_has_svm_feature(SVM_FEATURE_AVIC)
> > +#define cpu_has_svm_x2avic    cpu_has_svm_feature(SVM_FEATURE_X2AVIC)
> 
> ... and this is mostly ordered by feature number.  Maybe add an pre-req
> patch to sort them, and then re-do patch 2 and this patch to insert in
> feature order?

Will do.

> 
> Re-ordered (for both patches):
> 
> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
> 
> Thanks,
> Jason
>