Re: [PATCH v1 14/28] x86/hvm: vlapic: update signatures of both vlapic_{clear,test}_*

[dmukhin@ford.com]

On Thu, Nov 05, 2026 at 09:33:17AM +0100, Jan Beulich wrote:
> On 05.11.2026 02:33, dmukhin@ford.com wrote:
> > --- a/xen/arch/x86/hvm/vlapic.c
> > +++ b/xen/arch/x86/hvm/vlapic.c
> > @@ -85,14 +85,14 @@ static int vlapic_find_highest_vector(const void *bitmap)
> >   * IRR-specific bitmap update & search routines.
> >   */
> >  
> > -static int vlapic_test_and_set_irr(int vector, struct vlapic *vlapic)
> > +static int vlapic_test_and_set_irr(struct vlapic *vlapic, uint8_t vec)
> >  {
> > -    return vlapic_test_and_set_vector(vector, &vlapic->regs->data[APIC_IRR]);
> > +    return vlapic_test_and_set_vector(vec, &vlapic->regs->data[APIC_IRR]);
> >  }
> >  
> > -static void vlapic_clear_irr(int vector, struct vlapic *vlapic)
> > +static void vlapic_clear_irr(struct vlapic *vlapic, uint8_t vec)
> >  {
> > -    vlapic_clear_vector(vector, &vlapic->regs->data[APIC_IRR]);
> > +    vlapic_clear_vector(vec, &vlapic->regs->data[APIC_IRR]);
> >  }
> >  
> >  static int vlapic_find_highest_irr(struct vlapic *vlapic)
> 
> Each of the functions only having ...
> 
> > @@ -166,7 +166,7 @@ void vlapic_set_irq(struct vlapic *vlapic, uint8_t vec, uint8_t trig)
> >  
> >      if ( hvm_funcs.deliver_posted_intr )
> >          alternative_vcall(hvm_funcs.deliver_posted_intr, target, vec);
> > -    else if ( !vlapic_test_and_set_irr(vec, vlapic) )
> > +    else if ( !vlapic_test_and_set_irr(vlapic, vec) )
> >          vcpu_kick(target);
> >  }
> >  
> > @@ -1414,7 +1414,7 @@ int vlapic_ack_pending_irq(struct vcpu *v, int vector, bool force_ack)
> >           !viridian_synic_is_auto_eoi_sint(v, vector) )
> >          vlapic_set_vector(vector, &vlapic->regs->data[APIC_ISR]);
> >  
> > -    vlapic_clear_irr(vector, vlapic);
> > +    vlapic_clear_irr(vlapic, vector);
> >  
> >      return 1;
> >  }
> 
> ... a single caller: Do we actually need those helpers?

Yeah, I would rather drop these...
Thanks for suggestion!

> 
> Jan
>