All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins
@ 2026-10-27 13:51 Jeff Layton
  2026-10-28 17:09 ` Zorro Lang
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2026-10-27 13:51 UTC (permalink / raw)
  To: Zorro Lang; +Cc: fstests, Jeff Layton

b4 prep --auto-to-cc passes --nogit-chief-penguins as an option to
get_maintainer.pl. Ensure that it accepts and ignores it.

Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 tools/get_maintainer.pl | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tools/get_maintainer.pl b/tools/get_maintainer.pl
index 671ffe26a799..02c02eea3e67 100755
--- a/tools/get_maintainer.pl
+++ b/tools/get_maintainer.pl
@@ -31,6 +31,7 @@ my $email_fixes = 1;
 my $email_list = 1;
 my $email_moderated_list = 1;
 my $email_subscriber_list = 0;
+my $email_git_penguin_chiefs = 0;
 my $email_git = 0;
 my $email_git_all_signature_types = 0;
 my $email_git_blame = 0;
@@ -228,6 +229,7 @@ if (!GetOptions(
 		'git-blame!' => \$email_git_blame,
 		'git-blame-signatures!' => \$email_git_blame_signatures,
 		'git-fallback!' => \$email_git_fallback,
+		'git-chief-penguins!' => \$email_git_penguin_chiefs,
 		'git-min-signatures=i' => \$email_git_min_signatures,
 		'git-max-maintainers=i' => \$email_git_max_maintainers,
 		'git-min-percent=i' => \$email_git_min_percent,

---
base-commit: 22348afe338c0f6d540c0d7ef0db749eaa51b218
change-id: 20261027-b4-5ff755f4716c

Best regards,
-- 
Jeff Layton <jlayton@kernel.org>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins
  2026-10-27 13:51 [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins Jeff Layton
@ 2026-10-28 17:09 ` Zorro Lang
  2026-10-28 17:18   ` Jeff Layton
  0 siblings, 1 reply; 3+ messages in thread
From: Zorro Lang @ 2026-10-28 17:09 UTC (permalink / raw)
  To: Jeff Layton; +Cc: fstests

On Tue, Oct 27, 2026 at 09:51:54AM -0400, Jeff Layton wrote:
> b4 prep --auto-to-cc passes --nogit-chief-penguins as an option to
> get_maintainer.pl. Ensure that it accepts and ignores it.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---

Makes sense to me, thanks Jeff!

Reviewed-by: Zorro Lang <zlang@kernel.org>

Just out of curiosity, how did you configure your environment to trigger
this in fstests? Did you symlink "scripts" to "tools" (e.g. ln -s tools scripts),
or did you set some b4 git config :)

Thanks,
Zorro

>  tools/get_maintainer.pl | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tools/get_maintainer.pl b/tools/get_maintainer.pl
> index 671ffe26a799..02c02eea3e67 100755
> --- a/tools/get_maintainer.pl
> +++ b/tools/get_maintainer.pl
> @@ -31,6 +31,7 @@ my $email_fixes = 1;
>  my $email_list = 1;
>  my $email_moderated_list = 1;
>  my $email_subscriber_list = 0;
> +my $email_git_penguin_chiefs = 0;
>  my $email_git = 0;
>  my $email_git_all_signature_types = 0;
>  my $email_git_blame = 0;
> @@ -228,6 +229,7 @@ if (!GetOptions(
>  		'git-blame!' => \$email_git_blame,
>  		'git-blame-signatures!' => \$email_git_blame_signatures,
>  		'git-fallback!' => \$email_git_fallback,
> +		'git-chief-penguins!' => \$email_git_penguin_chiefs,
>  		'git-min-signatures=i' => \$email_git_min_signatures,
>  		'git-max-maintainers=i' => \$email_git_max_maintainers,
>  		'git-min-percent=i' => \$email_git_min_percent,
> 
> ---
> base-commit: 22348afe338c0f6d540c0d7ef0db749eaa51b218
> change-id: 20261027-b4-5ff755f4716c
> 
> Best regards,
> -- 
> Jeff Layton <jlayton@kernel.org>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins
  2026-10-28 17:09 ` Zorro Lang
@ 2026-10-28 17:18   ` Jeff Layton
  0 siblings, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2026-10-28 17:18 UTC (permalink / raw)
  To: fstests

On Thu, 2026-10-29 at 01:09 +0800, Zorro Lang wrote:
> On Tue, Oct 27, 2026 at 09:51:54AM -0400, Jeff Layton wrote:
> > b4 prep --auto-to-cc passes --nogit-chief-penguins as an option to
> > get_maintainer.pl. Ensure that it accepts and ignores it.
> > 
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> 
> Makes sense to me, thanks Jeff!
> 
> Reviewed-by: Zorro Lang <zlang@kernel.org>
> 
> Just out of curiosity, how did you configure your environment to trigger
> this in fstests? Did you symlink "scripts" to "tools" (e.g. ln -s tools scripts),
> or did you set some b4 git config :)
> 
> Thanks,
> Zorro
> 

Yes, actually -- I symlinked it. We could probably do that as part of
this patch if you like. I can respin or you can just add it.
 
> >  tools/get_maintainer.pl | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/tools/get_maintainer.pl b/tools/get_maintainer.pl
> > index 671ffe26a799..02c02eea3e67 100755
> > --- a/tools/get_maintainer.pl
> > +++ b/tools/get_maintainer.pl
> > @@ -31,6 +31,7 @@ my $email_fixes = 1;
> >  my $email_list = 1;
> >  my $email_moderated_list = 1;
> >  my $email_subscriber_list = 0;
> > +my $email_git_penguin_chiefs = 0;
> >  my $email_git = 0;
> >  my $email_git_all_signature_types = 0;
> >  my $email_git_blame = 0;
> > @@ -228,6 +229,7 @@ if (!GetOptions(
> >  		'git-blame!' => \$email_git_blame,
> >  		'git-blame-signatures!' => \$email_git_blame_signatures,
> >  		'git-fallback!' => \$email_git_fallback,
> > +		'git-chief-penguins!' => \$email_git_penguin_chiefs,
> >  		'git-min-signatures=i' => \$email_git_min_signatures,
> >  		'git-max-maintainers=i' => \$email_git_max_maintainers,
> >  		'git-min-percent=i' => \$email_git_min_percent,
> > 
> > ---
> > base-commit: 22348afe338c0f6d540c0d7ef0db749eaa51b218
> > change-id: 20261027-b4-5ff755f4716c
> > 
> > Best regards,
> > -- 
> > Jeff Layton <jlayton@kernel.org>
> > 

-- 
Jeff Layton <jlayton@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-10-28 17:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-27 13:51 [PATCH] tools/get_maintainer.pl: accept and ignore --nogit-chief-penguins Jeff Layton
2026-10-28 17:09 ` Zorro Lang
2026-10-28 17:18   ` Jeff Layton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.