[PATCH] rng: Remove deprecated "rng-backend" property "opened"

[PATCH] rng: Remove deprecated "rng-backend" property "opened"

[Markus Armbruster]

This property was deprecated in commit 6815bc1d03c (qapi/qom: Add
ObjectOptions for rng-*, deprecate 'opened') in v6.0.0.  Commit
6e577937485 (rng: make opened property read-only) in v7.1.0 made it
read-only, and also moved the its entry from docs/about/deprecated.rst
to docs/about/removed-features.rst.  I have no idea why it made the
property read-only instead of dropping it.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
 qapi/qom.json  | 22 ----------------------
 backends/rng.c | 11 -----------
 2 files changed, 33 deletions(-)

diff --git a/qapi/qom.json b/qapi/qom.json
index 4810d53e58..2a98b1de5f 100644
--- a/qapi/qom.json
+++ b/qapi/qom.json
@@ -925,25 +925,6 @@
   'data': { 'pci-bus': 'str',
             'node': 'uint32' } }
 
-##
-# @RngProperties:
-#     Properties for objects of classes derived from rng.
-#
-# @opened: if true, the device is opened immediately when applying
-#     this option and will probably fail when processing the next
-#     option.  Don't use; only provided for compatibility.
-#     (default: false)
-#
-# Features:
-#
-# @deprecated: Member @opened is deprecated.  Setting true doesn't
-#     make sense, and false is already the default.
-#
-# Since: 1.3
-##
-{ 'struct': 'RngProperties',
-  'data': { '*opened': { 'type': 'bool', 'features': ['deprecated'] } } }
-
 ##
 # @RngEgdProperties:
 #     Properties for rng-egd objects.
@@ -954,7 +935,6 @@
 # Since: 1.3
 ##
 { 'struct': 'RngEgdProperties',
-  'base': 'RngProperties',
   'data': { 'chardev': 'str' } }
 
 ##
@@ -967,7 +947,6 @@
 # Since: 1.3
 ##
 { 'struct': 'RngRandomProperties',
-  'base': 'RngProperties',
   'data': { '*filename': 'str' },
   'if': 'CONFIG_POSIX' }
 
@@ -1372,7 +1351,6 @@
       'pr-manager-helper':          { 'type': 'PrManagerHelperProperties',
                                       'if': 'CONFIG_LINUX' },
       'qtest':                      'QtestProperties',
-      'rng-builtin':                'RngProperties',
       'rng-egd':                    'RngEgdProperties',
       'rng-random':                 { 'type': 'RngRandomProperties',
                                       'if': 'CONFIG_POSIX' },
diff --git a/backends/rng.c b/backends/rng.c
index bc9c7a5ab3..08d57e47ab 100644
--- a/backends/rng.c
+++ b/backends/rng.c
@@ -41,13 +41,6 @@ void rng_backend_request_entropy(RngBackend *s, size_t size,
     }
 }
 
-static bool rng_backend_prop_get_opened(Object *obj, Error **errp)
-{
-    RngBackend *s = RNG_BACKEND(obj);
-
-    return s->opened;
-}
-
 static void rng_backend_complete(UserCreatable *uc, Error **errp)
 {
     RngBackend *s = RNG_BACKEND(uc);
@@ -123,10 +116,6 @@ static void rng_backend_class_init(ObjectClass *oc, const void *data)
     UserCreatableClass *ucc = USER_CREATABLE_CLASS(oc);
 
     ucc->complete = rng_backend_complete;
-
-    object_class_property_add_bool(oc, "opened",
-                                   rng_backend_prop_get_opened,
-                                   NULL);
 }
 
 static const TypeInfo rng_backend_info = {
-- 
2.55.0

Re: [PATCH] rng: Remove deprecated "rng-backend" property "opened"

[Daniel P. Berrangé]

On Wed, Oct 28, 2026 at 04:26:12PM +0100, Markus Armbruster wrote:
> This property was deprecated in commit 6815bc1d03c (qapi/qom: Add
> ObjectOptions for rng-*, deprecate 'opened') in v6.0.0.  Commit
> 6e577937485 (rng: make opened property read-only) in v7.1.0 made it
> read-only, and also moved the its entry from docs/about/deprecated.rst
> to docs/about/removed-features.rst.  I have no idea why it made the
> property read-only instead of dropping it.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  qapi/qom.json  | 22 ----------------------
>  backends/rng.c | 11 -----------
>  2 files changed, 33 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|