From: Drew Fustini <fustini@kernel.org>
To: Kanak Shilledar <kanak.shilledar@axis.com>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] riscv: dts: thead: th1520: Cleanup with dt-check-style
Date: Thu, 29 Oct 2026 18:29:24 -0700 [thread overview]
Message-ID: <auPy9Hwg5nXDb9fR@thelio> (raw)
In-Reply-To: <20261002-fix-dts-th1520-v1-2-9a8810091d47@axis.com>
On Fri, Oct 02, 2026 at 03:43:34PM +0200, Kanak Shilledar wrote:
> Fix warnings related to "property-order" and "required-blank-lines"
> reported from krzk's recent updates to dt-check-style tool. Leave
> out reordering of the nodes as it creates a very bit diff. After this
I will change this to "very big diff" when applying.
> patch only the following warnings remain which can be fixed in future
> work:
>
> thead/th1520.dtsi:221: [child-name-order] child node 'oscillator' out of name order
> thead/th1520.dtsi:227: [child-name-order] child node '32k-oscillator' out of name order
> thead/th1520.dtsi:248: [property-name] property name "snps,wr_osr_lmt" is using discouraged style
> thead/th1520.dtsi:249: [property-name] property name "snps,rd_osr_lmt" is using discouraged style
> thead/th1520.dtsi:253: [child-name-order] child node 'aon' out of name order
>
> Fix these warnings to make the file more readable and maintainable
> along with that to make it more compliant with the devicetree
> specifications.
>
> Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
Reviewed-by: Drew Fustini <fustini@kernel.org>
WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Kanak Shilledar <kanak.shilledar@axis.com>
Cc: Guo Ren <guoren@kernel.org>, Fu Wei <wefu@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <pjw@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
linux-riscv@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] riscv: dts: thead: th1520: Cleanup with dt-check-style
Date: Thu, 29 Oct 2026 18:29:24 -0700 [thread overview]
Message-ID: <auPy9Hwg5nXDb9fR@thelio> (raw)
In-Reply-To: <20261002-fix-dts-th1520-v1-2-9a8810091d47@axis.com>
On Fri, Oct 02, 2026 at 03:43:34PM +0200, Kanak Shilledar wrote:
> Fix warnings related to "property-order" and "required-blank-lines"
> reported from krzk's recent updates to dt-check-style tool. Leave
> out reordering of the nodes as it creates a very bit diff. After this
I will change this to "very big diff" when applying.
> patch only the following warnings remain which can be fixed in future
> work:
>
> thead/th1520.dtsi:221: [child-name-order] child node 'oscillator' out of name order
> thead/th1520.dtsi:227: [child-name-order] child node '32k-oscillator' out of name order
> thead/th1520.dtsi:248: [property-name] property name "snps,wr_osr_lmt" is using discouraged style
> thead/th1520.dtsi:249: [property-name] property name "snps,rd_osr_lmt" is using discouraged style
> thead/th1520.dtsi:253: [child-name-order] child node 'aon' out of name order
>
> Fix these warnings to make the file more readable and maintainable
> along with that to make it more compliant with the devicetree
> specifications.
>
> Signed-off-by: Kanak Shilledar <kanak.shilledar@axis.com>
Reviewed-by: Drew Fustini <fustini@kernel.org>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2026-10-30 1:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-02 13:43 [PATCH 0/4] riscv: dts: thead: Cleanup with dt-check-style Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar
2026-10-02 13:43 ` [PATCH 1/4] riscv: dts: thead: beaglev-ahead: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar
2026-10-30 1:27 ` Drew Fustini
2026-10-30 1:27 ` Drew Fustini
2026-10-02 13:43 ` [PATCH 2/4] riscv: dts: thead: th1520: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar
2026-10-30 1:29 ` Drew Fustini [this message]
2026-10-30 1:29 ` Drew Fustini
2026-10-02 13:43 ` [PATCH 3/4] riscv: dts: th1520-lichee-module-4a: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar
2026-10-30 1:30 ` Drew Fustini
2026-10-30 1:30 ` Drew Fustini
2026-10-02 13:43 ` [PATCH 4/4] riscv: dts: thead: th1520-lichee-pi-4a: " Kanak Shilledar
2026-10-02 13:43 ` Kanak Shilledar
2026-10-30 1:30 ` Drew Fustini
2026-10-30 1:30 ` Drew Fustini
2026-10-26 13:02 ` [PATCH 0/4] riscv: dts: thead: " Kanak Shilledar
2026-10-26 13:02 ` Kanak Shilledar
2026-10-30 1:31 ` Drew Fustini
2026-10-30 1:31 ` Drew Fustini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auPy9Hwg5nXDb9fR@thelio \
--to=fustini@kernel.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=guoren@kernel.org \
--cc=kanak.shilledar@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=pjw@kernel.org \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.