* [jarkko-tpmdd:master 12/12] drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
@ 2026-10-30 4:02 kernel test robot
2026-10-30 15:16 ` Jarkko Sakkinen
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2026-10-30 4:02 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git master
head: 7e8d0278a462f604dd884db39b76d0ac3c1ad652
commit: 7e8d0278a462f604dd884db39b76d0ac3c1ad652 [12/12] tpm: tis_i2c: Add reset delays for ST33KTPM2XI2C
config: arm64-randconfig-r2202-20261030 (https://download.01.org/0day-ci/archive/20261030/202610300451.H7bYZx2r-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
smatch: v0.5.0-9187-g5189e3fb
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261030/202610300451.H7bYZx2r-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610300451.H7bYZx2r-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
243 | if (len > TPM_I2C_BUFSIZE - 1)
| ^
drivers/char/tpm/tpm_tis_i2c.c:352:40: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
352 | phy->io_buf = devm_kzalloc(&dev->dev, TPM_I2C_BUFSIZE, GFP_KERNEL);
| ^
2 errors generated.
vim +/TPM_I2C_BUFSIZE +243 drivers/char/tpm/tpm_tis_i2c.c
bbc23a07b0728c Alexander Steffen 2022-06-08 232
bbc23a07b0728c Alexander Steffen 2022-06-08 233 static int tpm_tis_i2c_write_bytes(struct tpm_tis_data *data, u32 addr, u16 len,
bbc23a07b0728c Alexander Steffen 2022-06-08 234 const u8 *value,
bbc23a07b0728c Alexander Steffen 2022-06-08 235 enum tpm_tis_io_mode io_mode)
bbc23a07b0728c Alexander Steffen 2022-06-08 236 {
bbc23a07b0728c Alexander Steffen 2022-06-08 237 struct tpm_tis_i2c_phy *phy = to_tpm_tis_i2c_phy(data);
bbc23a07b0728c Alexander Steffen 2022-06-08 238 struct i2c_msg msg = { .addr = phy->i2c_client->addr };
bbc23a07b0728c Alexander Steffen 2022-06-08 239 u8 reg = tpm_tis_i2c_address_to_register(addr);
bbc23a07b0728c Alexander Steffen 2022-06-08 240 int ret;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 241 u16 wrote = 0;
bbc23a07b0728c Alexander Steffen 2022-06-08 242
4d6830bf773cec Arun Menon 2026-10-29 @243 if (len > TPM_I2C_BUFSIZE - 1)
bbc23a07b0728c Alexander Steffen 2022-06-08 244 return -EIO;
bbc23a07b0728c Alexander Steffen 2022-06-08 245
bbc23a07b0728c Alexander Steffen 2022-06-08 246 phy->io_buf[0] = reg;
bbc23a07b0728c Alexander Steffen 2022-06-08 247 msg.buf = phy->io_buf;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 248 while (wrote < len) {
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 249 /* write register and data in one go */
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 250 msg.len = sizeof(reg) + len - wrote;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 251 if (msg.len > I2C_SMBUS_BLOCK_MAX)
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 252 msg.len = I2C_SMBUS_BLOCK_MAX;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 253
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 254 memcpy(phy->io_buf + sizeof(reg), value + wrote,
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 255 msg.len - sizeof(reg));
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 256
bbc23a07b0728c Alexander Steffen 2022-06-08 257 ret = tpm_tis_i2c_retry_transfer_until_ack(data, &msg);
bbc23a07b0728c Alexander Steffen 2022-06-08 258 if (ret < 0)
bbc23a07b0728c Alexander Steffen 2022-06-08 259 return ret;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 260 wrote += msg.len - sizeof(reg);
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 261 }
bbc23a07b0728c Alexander Steffen 2022-06-08 262
bbc23a07b0728c Alexander Steffen 2022-06-08 263 return 0;
bbc23a07b0728c Alexander Steffen 2022-06-08 264 }
bbc23a07b0728c Alexander Steffen 2022-06-08 265
:::::: The code at line 243 was first introduced by commit
:::::: 4d6830bf773cec0a8d18d54fc5d1f58eb3846d6f tpm: tis_i2c: Use local 4KB buffer to limit memory usage
:::::: TO: Arun Menon <armenon@redhat.com>
:::::: CC: Jarkko Sakkinen <jarkko@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [jarkko-tpmdd:master 12/12] drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
2026-10-30 4:02 [jarkko-tpmdd:master 12/12] drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE' kernel test robot
@ 2026-10-30 15:16 ` Jarkko Sakkinen
0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2026-10-30 15:16 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all
On Fri, Oct 30, 2026 at 05:02:35AM +0100, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git master
> >> drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
> 243 | if (len > TPM_I2C_BUFSIZE - 1)
> | ^
> drivers/char/tpm/tpm_tis_i2c.c:352:40: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
> 352 | phy->io_buf = devm_kzalloc(&dev->dev, TPM_I2C_BUFSIZE, GFP_KERNEL);
> | ^
OK this my fault. I was sorting merge coflicts an so it happened.
I will fix my master within someh hours.
Br, Jarkko
^ permalink raw reply [flat|nested] 3+ messages in thread
* [jarkko-tpmdd:master 12/12] drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
@ 2026-10-31 0:56 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2026-10-31 0:56 UTC (permalink / raw)
To: Jarkko Sakkinen; +Cc: oe-kbuild-all
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git master
head: 7e8d0278a462f604dd884db39b76d0ac3c1ad652
commit: 7e8d0278a462f604dd884db39b76d0ac3c1ad652 [12/12] tpm: tis_i2c: Add reset delays for ST33KTPM2XI2C
config: um-randconfig-1001-20261031 (https://download.01.org/0day-ci/archive/20261031/202610310850.l6o9LNb6-lkp@intel.com/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project c2ea4440d4b64c148de4fdfca1fc2c437a0701e4)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261031/202610310850.l6o9LNb6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202610310850.l6o9LNb6-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/char/tpm/tpm_tis_i2c.c:13:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:27:
In file included from include/linux/kernel_stat.h:8:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:24:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:12:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:1209:55: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
1209 | return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
| ~~~~~~~~~~ ^
>> drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
243 | if (len > TPM_I2C_BUFSIZE - 1)
| ^~~~~~~~~~~~~~~
drivers/char/tpm/tpm_tis_i2c.c:352:40: error: use of undeclared identifier 'TPM_I2C_BUFSIZE'
352 | phy->io_buf = devm_kzalloc(&dev->dev, TPM_I2C_BUFSIZE, GFP_KERNEL);
| ^~~~~~~~~~~~~~~
1 warning and 2 errors generated.
vim +/TPM_I2C_BUFSIZE +243 drivers/char/tpm/tpm_tis_i2c.c
bbc23a07b0728c Alexander Steffen 2022-06-08 232
bbc23a07b0728c Alexander Steffen 2022-06-08 233 static int tpm_tis_i2c_write_bytes(struct tpm_tis_data *data, u32 addr, u16 len,
bbc23a07b0728c Alexander Steffen 2022-06-08 234 const u8 *value,
bbc23a07b0728c Alexander Steffen 2022-06-08 235 enum tpm_tis_io_mode io_mode)
bbc23a07b0728c Alexander Steffen 2022-06-08 236 {
bbc23a07b0728c Alexander Steffen 2022-06-08 237 struct tpm_tis_i2c_phy *phy = to_tpm_tis_i2c_phy(data);
bbc23a07b0728c Alexander Steffen 2022-06-08 238 struct i2c_msg msg = { .addr = phy->i2c_client->addr };
bbc23a07b0728c Alexander Steffen 2022-06-08 239 u8 reg = tpm_tis_i2c_address_to_register(addr);
bbc23a07b0728c Alexander Steffen 2022-06-08 240 int ret;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 241 u16 wrote = 0;
bbc23a07b0728c Alexander Steffen 2022-06-08 242
4d6830bf773cec Arun Menon 2026-10-29 @243 if (len > TPM_I2C_BUFSIZE - 1)
bbc23a07b0728c Alexander Steffen 2022-06-08 244 return -EIO;
bbc23a07b0728c Alexander Steffen 2022-06-08 245
bbc23a07b0728c Alexander Steffen 2022-06-08 246 phy->io_buf[0] = reg;
bbc23a07b0728c Alexander Steffen 2022-06-08 247 msg.buf = phy->io_buf;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 248 while (wrote < len) {
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 249 /* write register and data in one go */
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 250 msg.len = sizeof(reg) + len - wrote;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 251 if (msg.len > I2C_SMBUS_BLOCK_MAX)
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 252 msg.len = I2C_SMBUS_BLOCK_MAX;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 253
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 254 memcpy(phy->io_buf + sizeof(reg), value + wrote,
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 255 msg.len - sizeof(reg));
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 256
bbc23a07b0728c Alexander Steffen 2022-06-08 257 ret = tpm_tis_i2c_retry_transfer_until_ack(data, &msg);
bbc23a07b0728c Alexander Steffen 2022-06-08 258 if (ret < 0)
bbc23a07b0728c Alexander Steffen 2022-06-08 259 return ret;
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 260 wrote += msg.len - sizeof(reg);
83e7e5d89f04d1 Alexander Sverdlin 2023-05-24 261 }
bbc23a07b0728c Alexander Steffen 2022-06-08 262
bbc23a07b0728c Alexander Steffen 2022-06-08 263 return 0;
bbc23a07b0728c Alexander Steffen 2022-06-08 264 }
bbc23a07b0728c Alexander Steffen 2022-06-08 265
:::::: The code at line 243 was first introduced by commit
:::::: 4d6830bf773cec0a8d18d54fc5d1f58eb3846d6f tpm: tis_i2c: Use local 4KB buffer to limit memory usage
:::::: TO: Arun Menon <armenon@redhat.com>
:::::: CC: Jarkko Sakkinen <jarkko@kernel.org>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-31 0:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 4:02 [jarkko-tpmdd:master 12/12] drivers/char/tpm/tpm_tis_i2c.c:243:12: error: use of undeclared identifier 'TPM_I2C_BUFSIZE' kernel test robot
2026-10-30 15:16 ` Jarkko Sakkinen
-- strict thread matches above, loose matches on Subject: below --
2026-10-31 0:56 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.