All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stafford Horne <shorne@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: stefan.kristiansson@saunalahti.fi, lkp@intel.com,
	jonas@southpole.se, broonie@kernel.org, linux-mm@kvack.org,
	willy@infradead.org
Subject: Re: [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers
Date: Sun, 1 Nov 2026 07:34:57 +0000	[thread overview]
Message-ID: <aubrobg1lV24DH4h@antec> (raw)
In-Reply-To: <7e6799e4a26d4c87b28bfe1d0bab7d54.1@linux-foundation.org>

On Fri, Oct 23, 2026 at 05:52:47PM -0700, Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: openrisc: include asm/page.h before folded pgtable headers
> Date: Fri, 23 Oct 2026 17:37:53 -0700
> 
> An OpenRISC allmodconfig build fails while compiling the DRM TTM KUnit
> helpers:
> 
>   include/asm-generic/pgtable-nop4d.h:9:18: error:
>   unknown type name 'pgd_t'
> 
> The TTM header cleanup stopped including linux/pagemap.h from ttm_tt.h. 
> The remaining ttm_caching.h include pulls in linux/pgtable.h, which
> reaches OpenRISC's asm/pgtable.h before asm/page.h has supplied the pgd_t
> definition.
> 
> Include asm/page.h ahead of the generic folded page-table headers.  This
> restores the missing type definition and allows OpenRISC allmodconfig
> builds to get past this failure.

Hi Andrew,

Thanks for this I will queue this.

-Stafford

> Fixes: 2854902575ac ("drm: Remove pagemap from ttm_tt.h header")
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/202610240135.uFA85jSq-lkp@intel.com
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> 
>  arch/openrisc/include/asm/pgtable.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/arch/openrisc/include/asm/pgtable.h~openrisc-include-asm-page-before-folded-pgtable-headers
> +++ a/arch/openrisc/include/asm/pgtable.h
> @@ -21,6 +21,7 @@
>  #ifndef __ASM_OPENRISC_PGTABLE_H
>  #define __ASM_OPENRISC_PGTABLE_H
>  
> +#include <asm/page.h>
>  #include <asm-generic/pgtable-nopmd.h>
>  
>  #ifndef __ASSEMBLER__
> _


  reply	other threads:[~2026-11-01  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-24  0:52 [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers Andrew Morton
2026-11-01  7:34 ` Stafford Horne [this message]
2026-11-01 12:00   ` Matthew Wilcox
2026-11-01 22:38     ` Stafford Horne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aubrobg1lV24DH4h@antec \
    --to=shorne@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=broonie@kernel.org \
    --cc=jonas@southpole.se \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=stefan.kristiansson@saunalahti.fi \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.