All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers
@ 2026-10-24  0:52 Andrew Morton
  2026-11-01  7:34 ` Stafford Horne
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2026-10-24  0:52 UTC (permalink / raw)
  To: stefan.kristiansson, shorne, lkp, jonas, broonie, akpm, linux-mm,
	willy

From: Andrew Morton <akpm@linux-foundation.org>
Subject: openrisc: include asm/page.h before folded pgtable headers
Date: Fri, 23 Oct 2026 17:37:53 -0700

An OpenRISC allmodconfig build fails while compiling the DRM TTM KUnit
helpers:

  include/asm-generic/pgtable-nop4d.h:9:18: error:
  unknown type name 'pgd_t'

The TTM header cleanup stopped including linux/pagemap.h from ttm_tt.h. 
The remaining ttm_caching.h include pulls in linux/pgtable.h, which
reaches OpenRISC's asm/pgtable.h before asm/page.h has supplied the pgd_t
definition.

Include asm/page.h ahead of the generic folded page-table headers.  This
restores the missing type definition and allows OpenRISC allmodconfig
builds to get past this failure.

Fixes: 2854902575ac ("drm: Remove pagemap from ttm_tt.h header")
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/202610240135.uFA85jSq-lkp@intel.com
Cc: Jonas Bonn <jonas@southpole.se>
Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Cc: Stafford Horne <shorne@gmail.com>
Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
Cc: Mark Brown <broonie@kernel.org>
---

 arch/openrisc/include/asm/pgtable.h |    1 +
 1 file changed, 1 insertion(+)

--- a/arch/openrisc/include/asm/pgtable.h~openrisc-include-asm-page-before-folded-pgtable-headers
+++ a/arch/openrisc/include/asm/pgtable.h
@@ -21,6 +21,7 @@
 #ifndef __ASM_OPENRISC_PGTABLE_H
 #define __ASM_OPENRISC_PGTABLE_H
 
+#include <asm/page.h>
 #include <asm-generic/pgtable-nopmd.h>
 
 #ifndef __ASSEMBLER__
_


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers
  2026-10-24  0:52 [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers Andrew Morton
@ 2026-11-01  7:34 ` Stafford Horne
  2026-11-01 12:00   ` Matthew Wilcox
  0 siblings, 1 reply; 3+ messages in thread
From: Stafford Horne @ 2026-11-01  7:34 UTC (permalink / raw)
  To: Andrew Morton; +Cc: stefan.kristiansson, lkp, jonas, broonie, linux-mm, willy

On Fri, Oct 23, 2026 at 05:52:47PM -0700, Andrew Morton wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: openrisc: include asm/page.h before folded pgtable headers
> Date: Fri, 23 Oct 2026 17:37:53 -0700
> 
> An OpenRISC allmodconfig build fails while compiling the DRM TTM KUnit
> helpers:
> 
>   include/asm-generic/pgtable-nop4d.h:9:18: error:
>   unknown type name 'pgd_t'
> 
> The TTM header cleanup stopped including linux/pagemap.h from ttm_tt.h. 
> The remaining ttm_caching.h include pulls in linux/pgtable.h, which
> reaches OpenRISC's asm/pgtable.h before asm/page.h has supplied the pgd_t
> definition.
> 
> Include asm/page.h ahead of the generic folded page-table headers.  This
> restores the missing type definition and allows OpenRISC allmodconfig
> builds to get past this failure.

Hi Andrew,

Thanks for this I will queue this.

-Stafford

> Fixes: 2854902575ac ("drm: Remove pagemap from ttm_tt.h header")
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/202610240135.uFA85jSq-lkp@intel.com
> Cc: Jonas Bonn <jonas@southpole.se>
> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
> Cc: Stafford Horne <shorne@gmail.com>
> Cc: Matthew Wilcox (Oracle) <willy@infradead.org>
> Cc: Mark Brown <broonie@kernel.org>
> ---
> 
>  arch/openrisc/include/asm/pgtable.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/arch/openrisc/include/asm/pgtable.h~openrisc-include-asm-page-before-folded-pgtable-headers
> +++ a/arch/openrisc/include/asm/pgtable.h
> @@ -21,6 +21,7 @@
>  #ifndef __ASM_OPENRISC_PGTABLE_H
>  #define __ASM_OPENRISC_PGTABLE_H
>  
> +#include <asm/page.h>
>  #include <asm-generic/pgtable-nopmd.h>
>  
>  #ifndef __ASSEMBLER__
> _


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers
  2026-11-01  7:34 ` Stafford Horne
@ 2026-11-01 12:00   ` Matthew Wilcox
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2026-11-01 12:00 UTC (permalink / raw)
  To: Stafford Horne
  Cc: Andrew Morton, stefan.kristiansson, lkp, jonas, broonie, linux-mm

On Sun, Nov 01, 2026 at 07:34:57AM +0000, Stafford Horne wrote:
> On Fri, Oct 23, 2026 at 05:52:47PM -0700, Andrew Morton wrote:
> > From: Andrew Morton <akpm@linux-foundation.org>
> > Subject: openrisc: include asm/page.h before folded pgtable headers
> > Date: Fri, 23 Oct 2026 17:37:53 -0700
> > 
> > An OpenRISC allmodconfig build fails while compiling the DRM TTM KUnit
> > helpers:
> > 
> >   include/asm-generic/pgtable-nop4d.h:9:18: error:
> >   unknown type name 'pgd_t'
> > 
> > The TTM header cleanup stopped including linux/pagemap.h from ttm_tt.h. 
> > The remaining ttm_caching.h include pulls in linux/pgtable.h, which
> > reaches OpenRISC's asm/pgtable.h before asm/page.h has supplied the pgd_t
> > definition.
> > 
> > Include asm/page.h ahead of the generic folded page-table headers.  This
> > restores the missing type definition and allows OpenRISC allmodconfig
> > builds to get past this failure.
> 
> Hi Andrew,
> 
> Thanks for this I will queue this.

No, I'll take it.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-01 12:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-24  0:52 [PATCH 1/1] openrisc: include asm/page.h before folded pgtable headers Andrew Morton
2026-11-01  7:34 ` Stafford Horne
2026-11-01 12:00   ` Matthew Wilcox

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.