* [PATCH v2] iotests: add --quiet arg to hide env variable dump
@ 2026-11-02 16:34 Daniel P. Berrangé
2026-11-02 16:58 ` Eric Blake
0 siblings, 1 reply; 2+ messages in thread
From: Daniel P. Berrangé @ 2026-11-02 16:34 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, qemu-block, Hanna Reitz, Daniel P. Berrangé
Every test run dumps a long list of environment variable settings.
While this is often useful, if you are trying to reproduce a bug
while repeatedly running a single test it can be quiet noisy. Add
a --quiet flag to 'check' which allows the env variable dump to
be hidden. With this is only prints out the tests being run and
the overall status on completion.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qemu-iotests/check | 4 +++-
tests/qemu-iotests/testrunner.py | 8 +++++---
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 3941eac8e21..c8ba536970c 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -46,6 +46,8 @@ def make_argparser() -> argparse.ArgumentParser:
description="Test run options",
formatter_class=argparse.ArgumentDefaultsHelpFormatter)
+ p.add_argument('-q', '--quiet', action='store_true',
+ help='reduce output verbosity to only test results')
p.add_argument('-n', '--dry-run', action='store_true',
help='show me, do not run tests')
p.add_argument('-j', dest='jobs', type=int, default=1,
@@ -230,6 +232,6 @@ if __name__ == '__main__':
with TestRunner(env, tap=args.tap,
color=args.color) as tr:
paths = [os.path.join(env.source_iotests, t) for t in tests]
- ok = tr.run_tests(paths, args.jobs)
+ ok = tr.run_tests(paths, args.jobs, args.quiet)
if not ok:
sys.exit(1)
diff --git a/tests/qemu-iotests/testrunner.py b/tests/qemu-iotests/testrunner.py
index 729680da4aa..f35e65f805f 100644
--- a/tests/qemu-iotests/testrunner.py
+++ b/tests/qemu-iotests/testrunner.py
@@ -376,7 +376,8 @@ def run_test(self, test: str,
sys.stdout.flush()
return res
- def run_tests(self, tests: List[str], jobs: int = 1) -> bool:
+ def run_tests(self, tests: List[str], jobs: int = 1,
+ quiet: bool = False) -> bool:
n_run = 0
failed = []
notrun = []
@@ -384,9 +385,10 @@ def run_tests(self, tests: List[str], jobs: int = 1) -> bool:
if self.tap:
print('TAP version 13')
- self.env.print_env('# ')
+ if not quiet:
+ self.env.print_env('# ')
print('1..%d' % len(tests))
- else:
+ elif not quiet:
self.env.print_env()
test_field_width = max(len(os.path.basename(t)) for t in tests) + 2
--
2.56.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] iotests: add --quiet arg to hide env variable dump
2026-11-02 16:34 [PATCH v2] iotests: add --quiet arg to hide env variable dump Daniel P. Berrangé
@ 2026-11-02 16:58 ` Eric Blake
0 siblings, 0 replies; 2+ messages in thread
From: Eric Blake @ 2026-11-02 16:58 UTC (permalink / raw)
To: Daniel P. Berrangé; +Cc: qemu-devel, Kevin Wolf, qemu-block, Hanna Reitz
On Mon, Nov 02, 2026 at 04:34:47PM +0000, Daniel P. Berrangé wrote:
> Every test run dumps a long list of environment variable settings.
> While this is often useful, if you are trying to reproduce a bug
> while repeatedly running a single test it can be quiet noisy. Add
Humorous typo; you meant 'quite noisy'.
> a --quiet flag to 'check' which allows the env variable dump to
> be hidden. With this is only prints out the tests being run and
> the overall status on completion.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> tests/qemu-iotests/check | 4 +++-
> tests/qemu-iotests/testrunner.py | 8 +++++---
> 2 files changed, 8 insertions(+), 4 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc.
Virtualization: qemu.org | libguestfs.org
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-02 16:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-02 16:34 [PATCH v2] iotests: add --quiet arg to hide env variable dump Daniel P. Berrangé
2026-11-02 16:58 ` Eric Blake
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.