From: Kevin Wolf <kwolf@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>,
Hanna Reitz <hreitz@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: Re: [PATCH 06/13] iotests/298: add testcase for async writes with preallocation filter
Date: Tue, 3 Nov 2026 14:16:15 +0100 [thread overview]
Message-ID: <aunen7IblBe9-QFk@redhat.com> (raw)
In-Reply-To: <20260930165000.303236-7-den@openvz.org>
Am 30.09.2026 um 18:49 hat Denis V. Lunev geschrieben:
> From: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
>
> The testcase creates a 64G image with 1M clusters, generates a list of
> 1M aligned offsets and feeds aio_write commands with those offsets to
> qemu-io run with '--aio native --nocache'. Then we check the data
> written at each of the offsets. Before this series this could result
> in a race within the preallocation filter which would zeroize some
> clusters after actually writing data to them.
>
> Note: the test does not fail every time as there's a race involved, but
> the failures are pretty consistent so it should be good enough for
> detecting the problem.
>
> Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Kevin Wolf <kwolf@redhat.com>
> CC: Hanna Reitz <hreitz@redhat.com>
> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
FWIW, this doesn't seem to fail at all for me even without the fixes. I
kept it running in a loop for a while, but it always passed.
What is the bug this triggered for you? I don't think it can't be the
locking one because qemu-io tests are always single threaded.
If it is what patch 2 addressed, shouldn't a deterministic test be
possible in which you set a blkdebug breakpoint that suspends the
bdrv_co_pwrite_zeroes() before you launch another write?
Kevin
next prev parent reply other threads:[~2026-11-03 13:16 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 16:49 [PATCH 00/13] block: fix data loss in the preallocate filter Denis V. Lunev
2026-09-30 16:49 ` [PATCH 01/13] block/file-posix: drop the XFS workaround for post-EOF fallocate Denis V. Lunev
2026-10-02 16:16 ` Andrey Drobyshev
2026-09-30 16:49 ` [PATCH 02/13] block/preallocate: keep zero_start above written data Denis V. Lunev
2026-10-02 16:16 ` Andrey Drobyshev
2026-09-30 16:49 ` [PATCH 03/13] block/preallocate: collect the state assignments in one place Denis V. Lunev
2026-10-02 16:16 ` Andrey Drobyshev
2026-09-30 16:49 ` [PATCH 04/13] block/preallocate: serialise the filter state Denis V. Lunev
2026-10-02 16:16 ` Andrey Drobyshev
2026-11-03 12:45 ` Kevin Wolf
2026-09-30 16:49 ` [PATCH 05/13] block/preallocate: hold back writes into a preallocation in flight Denis V. Lunev
2026-10-02 16:16 ` Andrey Drobyshev
2026-11-03 13:01 ` Kevin Wolf
2026-09-30 16:49 ` [PATCH 06/13] iotests/298: add testcase for async writes with preallocation filter Denis V. Lunev
2026-11-03 13:16 ` Kevin Wolf [this message]
2026-09-30 16:49 ` [PATCH 07/13] tests/unit: prefix the iothread test helper Denis V. Lunev
2026-10-05 20:06 ` Eric Blake
2026-09-30 16:49 ` [PATCH 08/13] qemu-io: accept --object iothread Denis V. Lunev
2026-10-05 20:11 ` Eric Blake
2026-09-30 16:49 ` [PATCH 09/13] qemu-io: add -t to run an aio request in a named iothread Denis V. Lunev
2026-10-05 20:28 ` Eric Blake
2026-09-30 16:49 ` [PATCH 10/13] qemu-io: add -g to write past the end of the image Denis V. Lunev
2026-10-05 20:36 ` Eric Blake
2026-11-03 13:25 ` Kevin Wolf
2026-09-30 16:49 ` [PATCH 11/13] block/blkdebug: make a breakpoint work across AioContexts Denis V. Lunev
2026-10-05 20:42 ` Eric Blake
2026-11-03 13:32 ` Kevin Wolf
2026-09-30 16:49 ` [PATCH 12/13] block: add blkdebug events for a write before it is tracked Denis V. Lunev
2026-10-05 20:45 ` Eric Blake
2026-09-30 16:49 ` [PATCH 13/13] iotests/298: cover the preallocation races Denis V. Lunev
2026-10-05 21:06 ` Eric Blake
2026-11-03 13:48 ` Kevin Wolf
2026-10-30 11:12 ` [PATCH 00/13] block: fix data loss in the preallocate filter Denis V. Lunev
2026-11-03 13:49 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aunen7IblBe9-QFk@redhat.com \
--to=kwolf@redhat.com \
--cc=andrey.drobyshev@virtuozzo.com \
--cc=den@openvz.org \
--cc=hreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.