Re: [PATCH v6 07/20] LoongArch: lib: General routines

[Yao Zi <me@ziyao.cc>]

On Sat, Oct 31, 2026 at 01:43:10AM -0700, Simon Glass wrote:
> Hi Jiaxun,
> 
> On 2026-10-29T05:07:18+11:00, Yao Zi <me@ziyao.cc> wrote:
> > LoongArch: lib: General routines
> >
> > Add cache probing through CPUCFG, cache operations, setjmp()/longjump(),
> > and etc. for the architecture.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Yao Zi <me@ziyao.cc>
> >
> >  arch/loongarch/include/asm/cache.h       |  11 +-
> >  arch/loongarch/include/asm/global_data.h |   7 +
> >  arch/loongarch/lib/Makefile              |   7 +
> >  arch/loongarch/lib/asm-offsets.c         |  66 +++++++++
> >  arch/loongarch/lib/boot.c                |  14 ++
> >  arch/loongarch/lib/cache.c               | 235 +++++++++++++++++++++++++++++++
> >  arch/loongarch/lib/reset.c               |  14 ++
> >  arch/loongarch/lib/setjmp.S              |  52 +++++++
> >  8 files changed, 405 insertions(+), 1 deletion(-)
> 
> > diff --git a/arch/loongarch/include/asm/cache.h b/arch/loongarch/include/asm/cache.h
> > @@ -15,6 +17,13 @@ void cache_flush(void);
> > +#define CACHE_MAX_LEVEL		3
> > +#define CACHE_MAX_INDEX		6
> 
> Please can you add a short comment to these, saying that the first is
> the number of dcache levels tracked and the second is the number of
> cache IDs that CACOP can encode?

Sure.

> > diff --git a/arch/loongarch/lib/setjmp.S b/arch/loongarch/lib/setjmp.S
> > @@ -0,0 +1,52 @@
> > +ENTRY(setjmp)
> > +	LONG_S		s0, a0, 0
> > +	LONG_S 		s1, a0, (1 * LONGSIZE)
> 
> There is still a stray space after LONG_S here, and after LONG_L in
> longjmp() too.

I'll clean it up.

> In any case:
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Regards,
> Simon

Regards,
Yao Zi