Re: [PATCH v6 09/20] LoongArch: Exception handling

[Yao Zi <me@ziyao.cc>]

On Sat, Oct 31, 2026 at 01:43:22AM -0700, Simon Glass wrote:
> Hi Jiaxun,
> 
> On 2026-10-29T05:07:18+11:00, Yao Zi <me@ziyao.cc> wrote:
> > LoongArch: Exception handling
> >
> > Add exception entry assembly code, import stackframe.h
> > from Linux, provide debug prints when exception happens.
> >
> > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> > Signed-off-by: Yao Zi <me@ziyao.cc>
> >
> >  arch/loongarch/Kconfig                  |  19 ++++
> >  arch/loongarch/cpu/Makefile             |   2 +-
> >  arch/loongarch/cpu/genex.S              |  21 ++++
> >  arch/loongarch/include/asm/stackframe.h | 175 ++++++++++++++++++++++++++++++
> >  arch/loongarch/lib/interrupts.c         | 185 ++++++++++++++++++++++++++++++++
> >  5 files changed, 401 insertions(+), 1 deletion(-)
> 
> > diff --git a/arch/loongarch/lib/interrupts.c b/arch/loongarch/lib/interrupts.c
> > @@ -0,0 +1,185 @@
> > +#if IS_ENABLED(CONFIG_SHOW_REGS)
> > +	show_regs(regs);
> > +#endif
> 
> show_regs() is already __maybe_unused, so please can you use a plain
> if (IS_ENABLED(CONFIG_SHOW_REGS)) here, as you do for FRAMEPOINTER
> just below? LoongArch has no SPL support yet, so it is fine to leave
> out SPL_SHOW_REGS.

Sure, but I'll use CONFIG_IS_ENABLED to take care of SPL cases as well,
since I'll definitely work on SPL support later.

> In any case:
> Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> Regards,
> Simon

Best regards,
Yao Zi