From: Daniel Golle <daniel@makrotopia.org>
To: joseph@telaak.dev
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios
Date: Wed, 4 Nov 2026 07:38:30 +0000 [thread overview]
Message-ID: <aurg9vX3_i_ewWur@makrotopia.org> (raw)
In-Reply-To: <20261104-mxl-gsw1xx-reset-v1-2-53839bf5c88e@telaak.dev>
On Wed, Nov 04, 2026 at 02:15:48AM -0500, Joseph Telaak via B4 Relay wrote:
> From: Joseph Telaak <joseph@telaak.dev>
>
> The switch keeps the configuration the bootloader left in it, and the
> driver never resets it. The MDIO core asserts and releases reset-gpios
> only for PHY devices, so a reset line described on the switch node has
> no effect either.
>
> On the GL.iNet GL-SFT1200 the bootloader leaves each internal PHY of
> the GSW150 one MDIO address above its port. Port 0 then fails with
> "failed to connect to PHY: -ENODEV", and the PHY that answers at a
> port's address belongs to the neighbouring port. After a hardware reset
> every PHY is back at its port's address and all ports work.
>
> Request the reset GPIO in the driver and pulse it before the first
> register access. The timing follows the vendor driver: asserted for
> 2 ms, then 100 ms before the switch is accessed.
Any good reason to open-code this instead of using reset-gpio
(CONFIG_RESET_GPIO)?
next prev parent reply other threads:[~2026-11-04 7:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:15 [PATCH net-next 0/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak
2026-11-04 7:15 ` Joseph Telaak via B4 Relay
2026-11-04 7:15 ` [PATCH net-next 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios Joseph Telaak
2026-11-04 7:15 ` Joseph Telaak via B4 Relay
2026-11-04 21:49 ` Rob Herring (Arm)
2026-11-05 7:16 ` sashiko-bot
2026-11-05 21:21 ` Joseph Telaak
2026-11-04 7:15 ` [PATCH net-next 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak
2026-11-04 7:15 ` Joseph Telaak via B4 Relay
2026-11-04 7:38 ` Daniel Golle [this message]
2026-11-04 7:50 ` Joseph Telaak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aurg9vX3_i_ewWur@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=hauke@hauke-m.de \
--cc=joseph@telaak.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.