Re: [PATCH net-next 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: net: dsa: lantiq,gswip: split GSW1xx into separate schema
--

commit 436a7ee0b7ce4df05ec852987339de64af0a633a
Author: Joseph Telaak <joseph@telaak.dev>

dt-bindings: net: dsa: lantiq,gswip: add reset-gpios

This commit adds the reset-gpios property to the lantiq,gswip DSA switch
binding for standalone GSW1xx switches and disallows it on SoC-integrated
GSWIP variants.

> diff --git a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> index 49af5573e452d..9a74ea2a6dcdd 100644
> --- a/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
> @@ -40,6 +40,11 @@ properties:
>        - const: mdio
>        - const: mii
>  
> +  reset-gpios:
> +    maxItems: 1
> +    description:
> +      GPIO connected to the hardware reset input of a standalone switch.
> +
>    mdio:
>      $ref: /schemas/net/mdio.yaml#
>      unevaluatedProperties: false
> @@ -173,6 +178,7 @@ allOf:
>          mdio:
>            required:
>              - compatible
> +        reset-gpios: false

[Severity: Low]
This isn't a bug, but Documentation/devicetree/bindings/net/dsa/lantiq,gswip.yaml
combines two distinct hardware integration models: SoC-integrated MMIO
switches (lantiq,xrx200-gswip, lantiq,xrx300-gswip, lantiq,xrx330-gswip) and
standalone MDIO-attached switches (intel,gsw150, lantiq,peb7084, and
maxlinear,gsw1xx).

Because these two families sit on different buses and use different resources,
nearly every top-level property outside compatible and ports (reg, reg-names,
mdio, gphy-fw, and now reset-gpios) has to be conditionally constrained or
disallowed in the allOf if-then-else block:

  if:
    properties:
      compatible:
        contains:
          enum:
            - lantiq,xrx200-gswip
            - lantiq,xrx300-gswip
            - lantiq,xrx330-gswip
  then:
    properties:
      reg:
        minItems: 3
        maxItems: 3
      mdio:
        required:
          - compatible
      reset-gpios: false
  else:
    properties:
      reg:
        maxItems: 1
      reg-names: false
      gphy-fw: false

Instead of adding more variant-specific exclusions to this conditional, would
it make sense to split the standalone GSW1xx and SoC-integrated GSWIP bindings
into separate schema files?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261104-mxl-gsw1xx-reset-v1-0-53839bf5c88e@telaak.dev?part=1