All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: wait for encoded writes in fast fsync
Date: Wed, 4 Nov 2026 00:11:24 -0800	[thread overview]
Message-ID: <aurorIaI3EAocPQE@infradead.org> (raw)
In-Reply-To: <c284dccd8c27a6434e56ed067b0ef4ea67935d8c.1793776224.git.wqu@suse.com>

On Wed, Nov 04, 2026 at 05:40:46PM +1030, Qu Wenruo wrote:
> This is only covering encoded IO, not direct IO.
> 
> As we should not mix direct and buffered IO in the first place, fsync()
> definitely counts as a function in the buffered IO family.

It absolutely does not.  fsync/fdatasync covers all data and metadata
changes.  It is a fundamental part of O_DIRECT data integrity
operations to write back metadata and to flush disk caches.


  reply	other threads:[~2026-11-04  8:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-04  7:10 [PATCH RFC] btrfs: wait for encoded writes in fast fsync Qu Wenruo
2026-11-04  8:11 ` Christoph Hellwig [this message]
2026-11-04  8:14   ` Qu Wenruo
2026-11-04  8:46     ` Christoph Hellwig
2026-11-04 11:59     ` Filipe Manana
2026-11-04 11:57 ` Filipe Manana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aurorIaI3EAocPQE@infradead.org \
    --to=hch@infradead.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.