From: Christoph Hellwig <hch@infradead.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: Christoph Hellwig <hch@infradead.org>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFC] btrfs: wait for encoded writes in fast fsync
Date: Wed, 4 Nov 2026 00:46:22 -0800 [thread overview]
Message-ID: <aurw3n4G0fxBG4Uy@infradead.org> (raw)
In-Reply-To: <514c3590-27bd-42e0-b248-ec422a58e502@gmx.com>
On Wed, Nov 04, 2026 at 06:44:55PM +1030, Qu Wenruo wrote:
> > It absolutely does not. fsync/fdatasync covers all data and metadata
> > changes. It is a fundamental part of O_DIRECT data integrity
> > operations to write back metadata and to flush disk caches.
>
> Even if there is a direct write in the fly? How would you even detect it,
> there is no dirty page cache in the range.
In-flight I/O is per definition not captured by fsync. fsync applies
to previously completed I/O.
next prev parent reply other threads:[~2026-11-04 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 7:10 [PATCH RFC] btrfs: wait for encoded writes in fast fsync Qu Wenruo
2026-11-04 8:11 ` Christoph Hellwig
2026-11-04 8:14 ` Qu Wenruo
2026-11-04 8:46 ` Christoph Hellwig [this message]
2026-11-04 11:59 ` Filipe Manana
2026-11-04 11:57 ` Filipe Manana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aurw3n4G0fxBG4Uy@infradead.org \
--to=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.