Re: [Buildroot] [PATCH 1/2] package/wpewebkit: add missing libxkbcommon dependency

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Joseph,

Sorry for the silly questions, but I'm not super familiar with
wpewebkit.

On Mon, Nov 02, 2026 at 05:49:14PM -0500, Joseph Telaak wrote:
> WPE WebKit always needs libxkbcommon: OptionsWPE.cmake has an
> unconditional find_package(Libxkbcommon 0.4.0 REQUIRED). Today it is
> only pulled in indirectly, through libwpe, which wpebackend-fdo
> selects. That path goes away once wpebackend-fdo is optional, and

When does wpebackend-fdo becomes optional?

This patch doesn't make it optional, and neither does your PATCH 2/2.

> WebKit 2.52 can be built without libwpe at all
> (ENABLE_WPE_LEGACY_API=OFF). The WPE Platform library added by the
> next patch also links libxkbcommon itself.
> 
> Select it and add it to the dependencies directly.
> 
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Overall, is this fixing an actual build issue, or it's for
consistency, and preparation for wpebackend-fdo becoming optional in a
feature version of wpewebkit, which would break the wpewebkit ->
wpebackend-fdo -> libwpe -> libxkbcommon that exists today?

Adrian: review from you appreciated :-)

Thanks for your feedback!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot