All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Joseph Telaak <joseph@telaak.dev>
Cc: buildroot@buildroot.org, Adrian Perez de Castro <aperez@igalia.com>
Subject: Re: [Buildroot] [PATCH 2/2] package/wpewebkit: add WPE Platform options
Date: Wed, 4 Nov 2026 23:09:18 +0100	[thread overview]
Message-ID: <auusDZ8yOtO-Gebo@windsurf> (raw)
In-Reply-To: <20261102224915.69302-3-joseph@telaak.dev>

On Mon, Nov 02, 2026 at 05:49:15PM -0500, Joseph Telaak wrote:
> WPE Platform is the newer embedding API of WPE WebKit: the application
> creates a WPEDisplay and WebKit renders through it, without libwpe or
> a WPE backend.

Again, silly questions from someone not familiar with wpewebkit: what
is "WPE backend" in this context, and how does "WPE backend" map to
what we have (or don't have) in Buildroot?

In Buildroot as far as I can see, wpewebkit always depends on
wpebackend-fdo, which depends on libwpe. Does this mean that we are so
far only using "libwpe" and never "WPE backend"?

> In 2.50 it is only enabled by default in developer
> mode, so add an option for it, with sub-options for the DRM and
> Wayland platforms. The headless platform has no dependencies and is
> always built.
> 
> WPE Platform uses libmanette for gamepads when it finds it, so build
> libmanette first when it is enabled.
> 
> The DRM platform needs libinput and libudev. It also needs GBM and
> libdrm, which the existing USE_GBM and USE_LIBDRM blocks handle. It
> imports buffers for scanout with GBM format modifiers, which not every
> GBM provider supports, so, like cog, it depends on
> BR2_PACKAGE_LIBGBM_HAS_FEATURE_FORMAT_MODIFIER_PLANE_COUNT, the
> closest feature symbol. It does not use gbm_bo_get_fd, so unlike cog
> it does not need the DMA_BUF feature.

So far, so good.

> The Wayland platform selects wayland and wayland-protocols even though
> wpewebkit itself selects them today: that is only for wpebackend-fdo,
> and the Wayland platform needs them on its own.

But if wayland/wayland-protocols are only for wpebackend-fdo, why
isn't wpebackend-fdo selecting them, instead of wpewebkit?

> Every WPE Platform display compiles an XKB keymap with libxkbcommon.
> Without the xkeyboard-config data this fails and the application
> crashes, so select xkeyboard-config.
> 
> Pass ENABLE_WPE_PLATFORM explicitly in both cases, as upstream
> enables it by default starting with 2.54.
> 
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Otherwise, looks good to me. Probably no need to resend, just provide
a little bit more details on the questions asked on PATCH 1/2 and 2/2
and that should be good.

Adrian: here as well, your review would be appreciated :-)

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2026-11-04 22:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02 22:49 [Buildroot] [PATCH 0/2] package/wpewebkit: WPE Platform support Joseph Telaak
2026-11-02 22:49 ` [Buildroot] [PATCH 1/2] package/wpewebkit: add missing libxkbcommon dependency Joseph Telaak
2026-11-04 22:04   ` Thomas Petazzoni via buildroot
2026-11-05  0:21     ` Joseph Telaak
2026-11-02 22:49 ` [Buildroot] [PATCH 2/2] package/wpewebkit: add WPE Platform options Joseph Telaak
2026-11-04 22:09   ` Thomas Petazzoni via buildroot [this message]
2026-11-05  0:23     ` Joseph Telaak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auusDZ8yOtO-Gebo@windsurf \
    --to=buildroot@buildroot.org \
    --cc=aperez@igalia.com \
    --cc=joseph@telaak.dev \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.