From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: qemu-devel@nongnu.org, David Hildenbrand <david@kernel.org>,
Philippe Mathieu-Daude <philmd@mailo.com>,
Matthew Rosato <mjrosato@linux.ibm.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,
Cornelia Huck <cohuck@redhat.com>, Fam Zheng <fam@euphon.net>,
qemu-s390x@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Eric Farman <farman@linux.ibm.com>
Subject: Re: [PATCH 0/3] hw/(pci/scsi/virtio-mem): Avoid call to target_info() in class_init
Date: Thu, 5 Nov 2026 11:33:27 +0000 [thread overview]
Message-ID: <auxph3lmrvqnkchl@redhat.com> (raw)
In-Reply-To: <20261013200525.1340-1-luoyonggang@gmail.com>
On Wed, Oct 14, 2026 at 04:05:21AM +0800, Yonggang Luo wrote:
> Now we are going to delay the target select to machine select.
> So that avoid call to target_info() in class_init so that we wont
> face a NULL target_info() error when do class_init. This is because
> class_init is called under object_class_get_list(TYPE_MACHINE, false)
>
> Yonggang Luo (3):
> hw/pci: Avoid guard loadparm with target_s390x() for s390x in
> class_init
> hw/scsi: Avoid guard loadparm with target_s390x() for s390x in
> class_init
> hw/virtio/virtio-mem: Avoid call to target_info() in class_init
>
> hw/pci/pci.c | 18 ++++++++++--------
> hw/scsi/scsi-disk.c | 18 ++++++++++--------
> hw/virtio/virtio-mem.c | 12 +++++-------
> 3 files changed, 25 insertions(+), 23 deletions(-)
If the commit messages are fixed up,
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com ~~ https://hachyderm.io/@berrange :|
|: https://libvirt.org ~~ https://entangle-photo.org :|
|: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
prev parent reply other threads:[~2026-11-05 11:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 20:05 [PATCH 0/3] hw/(pci/scsi/virtio-mem): Avoid call to target_info() in class_init Yonggang Luo
2026-10-13 20:05 ` [PATCH 1/3] hw/pci: Avoid guard loadparm with target_s390x() for s390x " Yonggang Luo
2026-11-05 11:31 ` Daniel P. Berrangé
2026-10-13 20:05 ` [PATCH 2/3] hw/scsi: " Yonggang Luo
2026-10-13 20:05 ` [PATCH 3/3] hw/virtio/virtio-mem: Avoid call to target_info() " Yonggang Luo
2026-11-05 11:33 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auxph3lmrvqnkchl@redhat.com \
--to=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@kernel.org \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=luoyonggang@gmail.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@mailo.com \
--cc=pierrick.bouvier@oss.qualcomm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.