All of lore.kernel.org
 help / color / mirror / Atom feed
* [REGRESSION 6.12.y] Please backport 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")
@ 2026-11-03 21:58 The Darkbird
  2026-11-04 15:03 ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: The Darkbird @ 2026-11-03 21:58 UTC (permalink / raw)
  To: stable@vger.kernel.org
  Cc: regressions@lists.linux.dev, linux-sound@vger.kernel.org,
	eadavis@qq.com, tiwai@suse.de

Hello,

First of all: I noticed this regression on my LMDE 7 install and let 
Claude analyze the problem. I thoroughly read its analyses, read the kernel 
code diff involved, and I deemed it probable enough to mail it. However, I 
have no technical experience in this matter, nor with kernel-related coding, 
nor reporting regressions like these, so keep that in mind. I sincerely hope 
I won't be wasting your time with AI-generated nonsense.

-----

Please backport the following upstream commit to 6.12.y:

  70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")

It fixes ef5749ef8b30 ("ALSA: usb-audio: Prevent excessive number of
frames"), which went into 6.12.114 as commit 81e4b0009f2a. The fix
itself did not follow: it is not in 6.12.114 or 6.12.115, and it is not
in queue - 6.12 as of 2026-11-03. It has been in mainline since
v6.19-rc7, and 6.18.y already has both commits (6.18.10).

On 6.12.114 and later, USB audio playback is completely silent on
devices that use implicit feedback. In data_ep_set_params(),
ep->max_urb_frames is only assigned for playback endpoints without
implicit feedback, so for implicit-feedback playback it stays 0. The
check added to prepare_playback_urb()

    if (counts < 0 || frames + counts >= ep->max_urb_frames)

is then always true. The loop breaks before the first packet, frames
stays 0, and the function returns -EAGAIN for every URB, so no audio
data is ever sent. Players that sync video to the audio clock (mpv,
Firefox) show a black picture.

Hardware: MOTU UltraLite-mk5 (07fd:000c), which runs in implicit
feedback mode according to /proc/asound/cardN/stream0.

  6.12.113 (Debian 6.12.113-1): works
  6.12.115 (Debian 6.12.115-2): no sound at all

The code above is identical in upstream v6.12.115, so this is not
specific to Debian.

Note that 70b4db7d2581 does not apply cleanly to 6.12.y, because the
loop in prepare_playback_urb() is one indentation level shallower
there. The change itself is the same single line, and it applies with
"patch -l". I have not built and tested a 6.12 kernel with the fix.

The original report of the regression on mainline:
https://bugzilla.kernel.org/show_bug.cgi?id=220997

#regzbot introduced: 81e4b0009f2a

Thanks,
D.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [REGRESSION 6.12.y] Please backport 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")
  2026-11-03 21:58 [REGRESSION 6.12.y] Please backport 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check") The Darkbird
@ 2026-11-04 15:03 ` Sasha Levin
  2026-11-05 16:32   ` Salvatore Bonaccorso
  0 siblings, 1 reply; 3+ messages in thread
From: Sasha Levin @ 2026-11-04 15:03 UTC (permalink / raw)
  To: stable@vger.kernel.org
  Cc: Sasha Levin, regressions@lists.linux.dev,
	linux-sound@vger.kernel.org, eadavis@qq.com, tiwai@suse.de,
	The Darkbird

On 2026-11-03, The Darkbird <thedarkbird@protonmail.com> wrote:
> Please backport the following upstream commit to 6.12.y:
>
>   70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")

Queued for 6.12, thanks.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [REGRESSION 6.12.y] Please backport 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")
  2026-11-04 15:03 ` Sasha Levin
@ 2026-11-05 16:32   ` Salvatore Bonaccorso
  0 siblings, 0 replies; 3+ messages in thread
From: Salvatore Bonaccorso @ 2026-11-05 16:32 UTC (permalink / raw)
  To: Sasha Levin
  Cc: stable@vger.kernel.org, regressions@lists.linux.dev,
	linux-sound@vger.kernel.org, eadavis@qq.com, tiwai@suse.de,
	The Darkbird, benh

Hi Sasha,

On Wed, Nov 04, 2026 at 10:03:14AM -0500, Sasha Levin wrote:
> On 2026-11-03, The Darkbird <thedarkbird@protonmail.com> wrote:
> > Please backport the following upstream commit to 6.12.y:
> >
> >   70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check")
> 
> Queued for 6.12, thanks.

The commit ef5749ef8b30 ("ALSA: usb-audio: Prevent excessive number
of frames") introducing the issue was as well backported down to
6.1.191 and 6.6.160 additionall yto the found 6.12.114.

Should thus 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for
PCM OOB check") be queued as well for 6.6.y and 6.1.y?

Regards,
Salvatore

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-05 16:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-03 21:58 [REGRESSION 6.12.y] Please backport 70b4db7d2581 ("ALSA: usb-audio: Use the right limit for PCM OOB check") The Darkbird
2026-11-04 15:03 ` Sasha Levin
2026-11-05 16:32   ` Salvatore Bonaccorso

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.