All of lore.kernel.org
 help / color / mirror / Atom feed
From: Drew Fustini <fustini@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Sunil V L" <sunilvl@oss.qualcomm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Atish Patra" <atish.patra@linux.dev>,
	"Anup Patel" <anup.patel@oss.qualcomm.com>,
	"Chen Pei" <cp0613@linux.alibaba.com>,
	"yunhui cui" <cuiyunhui@bytedance.com>,
	"Reinette Chatre" <reinette.chatre@intel.com>,
	"Radim Krčmář" <radim.krcmar@oss.qualcomm.com>,
	"Zeng Heng" <zengheng@picoheart.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Ben Horgan" <ben.horgan@arm.com>,
	"James Morse" <james.morse@arm.com>,
	"Tony Luck" <tony.luck@intel.com>,
	"Adrien Ricciardi" <aricciardi@baylibre.com>,
	"Zhanpeng Zhang" <zhangzhanpeng.jasper@bytedance.com>,
	"Gong Shuai" <gong.shuai@sanechips.com.cn>,
	"Gong Shuai" <gsh517@gmail.com>,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Kornel Dulęba" <mindal@semihalf.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn,
	"Dave Martin" <Dave.Martin@arm.com>,
	"Babu Moger" <babu.moger@amd.com>,
	"Fenghua Yu" <fenghuay@nvidia.com>,
	"Peter Newman" <peternewman@google.com>,
	"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] riscv_cbqri: Bind to RQSC platform devices
Date: Thu, 19 Nov 2026 16:05:52 -0800	[thread overview]
Message-ID: <av-O4EoModkN73WK@thelio> (raw)
In-Reply-To: <20261118234904.0f6a0f17@jic23-hlaptop>

On Wed, Nov 18, 2026 at 11:49:04PM +0000, Jonathan Cameron wrote:
> On Tue, 17 Nov 2026 14:11:29 -0800
> "Drew Fustini (Tenstorrent)" <fustini@kernel.org> wrote:
> 
> > Let the capacity controller driver probe the "cbqri-capacity" platform
> > devices created from the RQSC table. The cache is named by its PPTT
> > Cache ID and the PPTT gives its level. Select ACPI_RQSC so the table is
> > parsed and drop the OF dependency.
> > 
> > No change for device tree systems.
> > 
> > Signed-off-by: Drew Fustini (Tenstorrent) <fustini@kernel.org>
> 
> Has the DT support landed? If not feels like a few tweaks in that
> would make this less noisy.
>
> If not, see below for one tidy up I'd make here if you can't push
> it back to that series.

Sure, I will roll the changes around cbqri_capacity_of_cache() into a
v13 and leave that out of this patch.

> You almost never want to do manual device_node puts these days!
> 
> It's one of the nicest places to use the cleanup.h magic.

Good idea, I will use it for device_node.

> >  	cache_np = of_parse_phandle(dev->of_node, "riscv,cbqri-cache", 0);
> Whilst you are here.
> 	struct device_node *cache_np __free(device_node) =
> 		of_parse_phandle();
> and drop all the gotos. I haven't checked but if there is
> a path where you want to hang on to it, no_free_ptr() that.

Will do. There should not be a need for no_free_ptr() for this one.

Thanks,
Drew


WARNING: multiple messages have this Message-ID (diff)
From: Drew Fustini <fustini@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Sunil V L" <sunilvl@oss.qualcomm.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"Len Brown" <lenb@kernel.org>, "Paul Walmsley" <pjw@kernel.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Albert Ou" <aou@eecs.berkeley.edu>,
	"Alexandre Ghiti" <alex@ghiti.fr>,
	"Atish Patra" <atish.patra@linux.dev>,
	"Anup Patel" <anup.patel@oss.qualcomm.com>,
	"Chen Pei" <cp0613@linux.alibaba.com>,
	"yunhui cui" <cuiyunhui@bytedance.com>,
	"Reinette Chatre" <reinette.chatre@intel.com>,
	"Radim Krčmář" <radim.krcmar@oss.qualcomm.com>,
	"Zeng Heng" <zengheng@picoheart.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Ben Horgan" <ben.horgan@arm.com>,
	"James Morse" <james.morse@arm.com>,
	"Tony Luck" <tony.luck@intel.com>,
	"Adrien Ricciardi" <aricciardi@baylibre.com>,
	"Zhanpeng Zhang" <zhangzhanpeng.jasper@bytedance.com>,
	"Gong Shuai" <gong.shuai@sanechips.com.cn>,
	"Gong Shuai" <gsh517@gmail.com>,
	"Weiwei Li" <liwei1518@gmail.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>,
	"Kornel Dulęba" <mindal@semihalf.com>,
	"Samuel Holland" <samuel.holland@sifive.com>,
	guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn,
	"Dave Martin" <Dave.Martin@arm.com>,
	"Babu Moger" <babu.moger@amd.com>,
	"Fenghua Yu" <fenghuay@nvidia.com>,
	"Peter Newman" <peternewman@google.com>,
	"Shaopeng Tan" <tan.shaopeng@jp.fujitsu.com>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	linux-acpi@vger.kernel.org, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] riscv_cbqri: Bind to RQSC platform devices
Date: Thu, 19 Nov 2026 16:05:52 -0800	[thread overview]
Message-ID: <av-O4EoModkN73WK@thelio> (raw)
In-Reply-To: <20261118234904.0f6a0f17@jic23-hlaptop>

On Wed, Nov 18, 2026 at 11:49:04PM +0000, Jonathan Cameron wrote:
> On Tue, 17 Nov 2026 14:11:29 -0800
> "Drew Fustini (Tenstorrent)" <fustini@kernel.org> wrote:
> 
> > Let the capacity controller driver probe the "cbqri-capacity" platform
> > devices created from the RQSC table. The cache is named by its PPTT
> > Cache ID and the PPTT gives its level. Select ACPI_RQSC so the table is
> > parsed and drop the OF dependency.
> > 
> > No change for device tree systems.
> > 
> > Signed-off-by: Drew Fustini (Tenstorrent) <fustini@kernel.org>
> 
> Has the DT support landed? If not feels like a few tweaks in that
> would make this less noisy.
>
> If not, see below for one tidy up I'd make here if you can't push
> it back to that series.

Sure, I will roll the changes around cbqri_capacity_of_cache() into a
v13 and leave that out of this patch.

> You almost never want to do manual device_node puts these days!
> 
> It's one of the nicest places to use the cleanup.h magic.

Good idea, I will use it for device_node.

> >  	cache_np = of_parse_phandle(dev->of_node, "riscv,cbqri-cache", 0);
> Whilst you are here.
> 	struct device_node *cache_np __free(device_node) =
> 		of_parse_phandle();
> and drop all the gotos. I haven't checked but if there is
> a path where you want to hang on to it, no_free_ptr() that.

Will do. There should not be a need for no_free_ptr() for this one.

Thanks,
Drew


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

  reply	other threads:[~2026-11-20  0:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 22:11 [PATCH 0/3] ACPI: RISC-V: Add support for the RQSC table Drew Fustini (Tenstorrent)
2026-11-17 22:11 ` Drew Fustini (Tenstorrent)
2026-11-17 22:11 ` [PATCH 1/3] ACPI: RISC-V: Add RQSC table definitions Drew Fustini (Tenstorrent)
2026-11-17 22:11   ` Drew Fustini (Tenstorrent)
2026-11-18 20:37   ` Jonathan Cameron
2026-11-18 20:37     ` Jonathan Cameron
2026-11-18 21:31     ` Drew Fustini
2026-11-18 21:31       ` Drew Fustini
2026-11-17 22:11 ` [PATCH 2/3] ACPI: RISC-V: Enumerate CBQRI controllers from the RQSC table Drew Fustini (Tenstorrent)
2026-11-17 22:11   ` Drew Fustini (Tenstorrent)
2026-11-18 23:42   ` Jonathan Cameron
2026-11-18 23:42     ` Jonathan Cameron
2026-11-19 22:02     ` Drew Fustini
2026-11-19 22:02       ` Drew Fustini
2026-11-17 22:11 ` [PATCH 3/3] riscv_cbqri: Bind to RQSC platform devices Drew Fustini (Tenstorrent)
2026-11-17 22:11   ` Drew Fustini (Tenstorrent)
2026-11-18 23:49   ` Jonathan Cameron
2026-11-18 23:49     ` Jonathan Cameron
2026-11-20  0:05     ` Drew Fustini [this message]
2026-11-20  0:05       ` Drew Fustini
2026-11-19 11:12   ` [External] " yunhui cui
2026-11-19 11:12     ` yunhui cui
2026-11-20  0:41     ` Drew Fustini
2026-11-20  0:41       ` Drew Fustini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av-O4EoModkN73WK@thelio \
    --to=fustini@kernel.org \
    --cc=Dave.Martin@arm.com \
    --cc=alex@ghiti.fr \
    --cc=anup.patel@oss.qualcomm.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=aricciardi@baylibre.com \
    --cc=atish.patra@linux.dev \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=conor.dooley@microchip.com \
    --cc=cp0613@linux.alibaba.com \
    --cc=cuiyunhui@bytedance.com \
    --cc=fenghuay@nvidia.com \
    --cc=gong.shuai@sanechips.com.cn \
    --cc=gsh517@gmail.com \
    --cc=guo.wenjia23@zte.com.cn \
    --cc=james.morse@arm.com \
    --cc=jic23@kernel.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=liu.qingtao2@zte.com.cn \
    --cc=liwei1518@gmail.com \
    --cc=mindal@semihalf.com \
    --cc=palmer@dabbelt.com \
    --cc=peternewman@google.com \
    --cc=pjw@kernel.org \
    --cc=radim.krcmar@oss.qualcomm.com \
    --cc=rafael@kernel.org \
    --cc=reinette.chatre@intel.com \
    --cc=samuel.holland@sifive.com \
    --cc=sunilvl@oss.qualcomm.com \
    --cc=tan.shaopeng@jp.fujitsu.com \
    --cc=tony.luck@intel.com \
    --cc=zengheng@picoheart.com \
    --cc=zhangzhanpeng.jasper@bytedance.com \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.