From: Cyril Hrubis <chrubis@suse.cz>
To: Darren Chang <chihsheng@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sys_block_queue01: Accept plain "none" in queue/scheduler
Date: Wed, 18 Nov 2026 10:11:02 +0100 [thread overview]
Message-ID: <av1rphtgXHMQzG9Z@yuki.lan> (raw)
In-Reply-To: <20261118063445.2137150-1-chihsheng@google.com>
Hi!
> + /*
> + * elv_iosched_show() emits plain "none\n" without brackets for queues
> + * that do not support I/O schedulers (bio-based devices prior to 6.5,
> + * and BLK_MQ_F_NO_SCHED devices prior to 6.14).
> + */
> + if (!strcmp(sched, "none")) {
> + tst_res(TPASS, PATH_SYS_BLOCK "/%s/queue/scheduler = 'none'", dev);
> + return;
> + }
> +
> + TST_SYSFS_ASSERT_CHOICE(sched_allowed, NULL, 0,
> + PATH_SYS_BLOCK "/%s/queue/scheduler", dev);
This does not make any sense. Why haven't you simply added "none" to the
sched_allowed array instead?
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-11-18 9:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:34 [LTP] [PATCH] sys_block_queue01: Accept plain "none" in queue/scheduler Darren Chang via ltp
2026-11-18 9:11 ` Cyril Hrubis [this message]
2026-11-18 16:33 ` Darren Chang via ltp
2026-11-19 11:21 ` Cyril Hrubis
2026-11-19 11:24 ` Cyril Hrubis
2026-11-19 16:25 ` [LTP] [PATCH v2] " Darren Chang via ltp
2026-11-19 21:03 ` [LTP] " linuxtestproject.agent
2026-11-20 9:47 ` [LTP] [PATCH v2] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av1rphtgXHMQzG9Z@yuki.lan \
--to=chrubis@suse.cz \
--cc=chihsheng@google.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.