From: Cyril Hrubis <chrubis@suse.cz>
To: Darren Chang <chihsheng@google.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] sys_block_queue01: Accept plain "none" in queue/scheduler
Date: Thu, 19 Nov 2026 12:21:43 +0100 [thread overview]
Message-ID: <av7bx1Jlg71UMVeE@yuki.lan> (raw)
In-Reply-To: <20261118163322.3334900-1-chihsheng@google.com>
Hi!
> > This does not make any sense. Why haven't you simply added "none" to the
> > sched_allowed array instead?
>
> "none" is already in sched_allowed[] (line 35 before this patch).
>
> The test fails because elv_iosched_show() prints "none\n" without brackets,
> not "[none]\n". TST_SYSFS_ASSERT_CHOICE() requires one bracketed token, so
> it fails with "0 selected tokens, expected exactly 1".
Sorry missed, that, I should have read the commit message better.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-11-19 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 6:34 [LTP] [PATCH] sys_block_queue01: Accept plain "none" in queue/scheduler Darren Chang via ltp
2026-11-18 9:11 ` Cyril Hrubis
2026-11-18 16:33 ` Darren Chang via ltp
2026-11-19 11:21 ` Cyril Hrubis [this message]
2026-11-19 11:24 ` Cyril Hrubis
2026-11-19 16:25 ` [LTP] [PATCH v2] " Darren Chang via ltp
2026-11-19 21:03 ` [LTP] " linuxtestproject.agent
2026-11-20 9:47 ` [LTP] [PATCH v2] " Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7bx1Jlg71UMVeE@yuki.lan \
--to=chrubis@suse.cz \
--cc=chihsheng@google.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.