* Re: [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
2026-11-18 10:34 [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup Adrian Huang (Lenovo)
@ 2026-11-18 12:12 ` Lorenzo Stoakes (ARM)
2026-11-19 5:54 ` Andrew Morton
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Lorenzo Stoakes (ARM) @ 2026-11-18 12:12 UTC (permalink / raw)
To: Adrian Huang (Lenovo)
Cc: Suren Baghdasaryan, Andrew Morton, Liam R . Howlett,
Vlastimil Babka, Jann Horn, Pedro Falcato, linux-mm, linux-kernel,
linux-fsdevel, ahuang12
(micro-nit - no need to say 1/1 for a single patch :)
On Wed, Nov 18, 2026 at 06:34:21PM +0800, Adrian Huang (Lenovo) wrote:
> Commit 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under
> per-vma lock") introduced the possibility of returning -EINTR from
> proc_get_vma() when a fatal signal interrupts mmap_read_lock_killable().
>
> The issue can be reproduced using stress-ng's VMA stressor, which reads
> /proc/self/maps while concurrently modifying VMAs and periodically
> terminates child processes with SIGKILL. The reproduced command is:
>
> # stress-ng --vma 0 -t 60
>
> When the VMA lookup is interrupted, proc_get_vma() returns an error
> pointer without advancing the position index. Consequently,
> seq_read_iter() emits the following rate-limited informational message:
>
> seq_file: buggy .next function m_next did not update position index
>
> Save the current position in priv->last_pos before checking the VMA
> lookup result, allowing it to be reused by both successful and error
> paths. Advance the position index when returning an error to avoid
> the spurious warning, while preserving the original error handling.
>
> Suggested-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
LGTM and:
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> ---
> Changes since v1:
> - Simplify the error handling and comments as suggested by Lorenzo.
> - Clarify the fatal-signal trigger and the cosmetic nature of the warning.
>
> fs/proc/task_mmu.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 22361607020d..564e52f7ddc6 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -216,16 +216,17 @@ static struct vm_area_struct *proc_get_vma(struct seq_file *m, loff_t *ppos)
>
> retry:
> vma = get_next_vma(priv, *ppos);
> - /* EINTR of EAGAIN is possible */
> + /* Store previous position to be able to restart if needed */
> + priv->last_pos = *ppos;
> if (IS_ERR(vma)) {
> if (PTR_ERR(vma) == -EAGAIN && fallback_to_mmap_lock(priv, *ppos))
> goto retry;
>
> + /* Advance to avoid spurious buggy seq warning in dmesg */
> + (*ppos)++;
> return vma;
> }
>
> - /* Store previous position to be able to restart if needed */
> - priv->last_pos = *ppos;
> if (vma) {
> /*
> * Track the end of the reported vma to ensure position changes
> --
> 2.43.0
>
--
Cheers, Lorenzo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
2026-11-18 10:34 [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup Adrian Huang (Lenovo)
2026-11-18 12:12 ` Lorenzo Stoakes (ARM)
@ 2026-11-19 5:54 ` Andrew Morton
2026-11-19 5:54 ` + fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch added to mm-new branch Andrew Morton
2026-11-19 10:35 ` [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup sashiko-bot
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2026-11-19 5:54 UTC (permalink / raw)
To: Adrian Huang (Lenovo)
Cc: Suren Baghdasaryan, Lorenzo Stoakes, Liam R . Howlett,
Vlastimil Babka, Jann Horn, Pedro Falcato, linux-mm, linux-kernel,
linux-fsdevel, ahuang12
On Wed, 18 Nov 2026 18:34:21 +0800 "Adrian Huang (Lenovo)" <adrianhuang0701@gmail.com> wrote:
> Commit 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under
> per-vma lock") introduced the possibility of returning -EINTR from
> proc_get_vma() when a fatal signal interrupts mmap_read_lock_killable().
>
> The issue can be reproduced using stress-ng's VMA stressor, which reads
> /proc/self/maps while concurrently modifying VMAs and periodically
> terminates child processes with SIGKILL. The reproduced command is:
>
> # stress-ng --vma 0 -t 60
>
> When the VMA lookup is interrupted, proc_get_vma() returns an error
> pointer without advancing the position index. Consequently,
> seq_read_iter() emits the following rate-limited informational message:
>
> seq_file: buggy .next function m_next did not update position index
Thanks. That's just bad behavior.
> Save the current position in priv->last_pos before checking the VMA
> lookup result, allowing it to be reused by both successful and error
> paths. Advance the position index when returning an error to avoid
> the spurious warning, while preserving the original error handling.
So I'll add a cc:stable to this, target the next merge window.
^ permalink raw reply [flat|nested] 5+ messages in thread* + fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch added to mm-new branch
2026-11-18 10:34 [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup Adrian Huang (Lenovo)
2026-11-18 12:12 ` Lorenzo Stoakes (ARM)
2026-11-19 5:54 ` Andrew Morton
@ 2026-11-19 5:54 ` Andrew Morton
2026-11-19 10:35 ` [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup sashiko-bot
3 siblings, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2026-11-19 5:54 UTC (permalink / raw)
To: mm-commits, vbabka, surenb, stable, pfalcato, ljs, liam, jannh,
ahuang12, adrianhuang0701, akpm
The patch titled
Subject: fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
has been added to the -mm mm-new branch. Its filename is
fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch
This patch will shortly appear at
https://git.kernel.org/pub/scm/linux/kernel/git/akpm/25-new.git/tree/patches/fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch
This patch will later appear in the mm-new branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
Note, mm-new is a provisional staging ground for work-in-progress
patches, and acceptance into mm-new is a notification for others take
notice and to finish up reviews. Please do not hesitate to respond to
review feedback and post updated versions to replace or incrementally
fixup patches in mm-new.
The mm-new branch of mm.git is not included in linux-next
If a few days of testing in mm-new is successful, the patch will me moved
into mm.git's mm-unstable branch, which is included in linux-next
Before you just go and hit "reply", please:
a) Consider who else should be cc'ed
b) Prefer to cc a suitable mailing list as well
c) Ideally: find the original patch on the mailing list and do a
reply-to-all to that, adding suitable additional cc's
*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
The -mm tree is included into linux-next via various
branches at git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
and is updated there most days
------------------------------------------------------
From: "Adrian Huang (Lenovo)" <adrianhuang0701@gmail.com>
Subject: fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
Date: Wed, 18 Nov 2026 18:34:21 +0800
Commit 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under per-vma
lock") introduced the possibility of returning -EINTR from proc_get_vma()
when a fatal signal interrupts mmap_read_lock_killable().
The issue can be reproduced using stress-ng's VMA stressor, which reads
/proc/self/maps while concurrently modifying VMAs and periodically
terminates child processes with SIGKILL. The reproduced command is:
# stress-ng --vma 0 -t 60
When the VMA lookup is interrupted, proc_get_vma() returns an error
pointer without advancing the position index. Consequently,
seq_read_iter() emits the following rate-limited informational message:
seq_file: buggy .next function m_next did not update position index
Save the current position in priv->last_pos before checking the VMA lookup
result, allowing it to be reused by both successful and error paths.
Advance the position index when returning an error to avoid the spurious
warning, while preserving the original error handling.
Link: https://patch.msgid.link/20261118103421.776-1-adrianhuang0701@gmail.com
Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Suggested-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Reviewed-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Liam R. Howlett <liam@infradead.org>
Cc: Vlastimil Babka <vbabka@kernel.org>
Cc: Jann Horn <jannh@google.com>
Cc: Pedro Falcato <pfalcato@suse.de>
Cc: Adrian Huang <ahuang12@lenovo.com>
Cc: <stable@vger.kernel.org>
fs/proc/task_mmu.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--- a/fs/proc/task_mmu.c~fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup
+++ a/fs/proc/task_mmu.c
@@ -216,16 +216,17 @@ static struct vm_area_struct *proc_get_v
retry:
vma = get_next_vma(priv, *ppos);
- /* EINTR of EAGAIN is possible */
+ /* Store previous position to be able to restart if needed */
+ priv->last_pos = *ppos;
if (IS_ERR(vma)) {
if (PTR_ERR(vma) == -EAGAIN && fallback_to_mmap_lock(priv, *ppos))
goto retry;
+ /* Advance to avoid spurious buggy seq warning in dmesg */
+ (*ppos)++;
return vma;
}
- /* Store previous position to be able to restart if needed */
- priv->last_pos = *ppos;
if (vma) {
/*
* Track the end of the reported vma to ensure position changes
_
Patches currently in -mm which might be from adrianhuang0701@gmail.com are
mm-damon-core-remove-unnecessary-zero-initialization-in-damon_new_ctx.patch
docs-admin-guide-mm-damon-fix-various-typos.patch
docs-admin-guide-mm-damon-lru_sort-fix-copy-paste-mistakes.patch
docs-admin-guide-mm-damon-usage-fix-incorrect-option-syntax-in-perf-example.patch
fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
2026-11-18 10:34 [PATCH mm-unstable v2 1/1] fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup Adrian Huang (Lenovo)
` (2 preceding siblings ...)
2026-11-19 5:54 ` + fs-proc-task_mmu-avoid-spurious-seq_file-warning-on-interrupted-vma-lookup.patch added to mm-new branch Andrew Morton
@ 2026-11-19 10:35 ` sashiko-bot
3 siblings, 0 replies; 5+ messages in thread
From: sashiko-bot @ 2026-11-19 10:35 UTC (permalink / raw)
To: Adrian Huang (Lenovo), Suren Baghdasaryan, Lorenzo Stoakes
Cc: Andrew Morton, Liam R . Howlett, Vlastimil Babka, Jann Horn,
Pedro Falcato, linux-mm, ahuang12
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] fs/proc/task_mmu: missing Fixes trailer for commit 5631da56c9a8
--
commit ea1e2d22fcfe8a8b373cfb53c201e13a9ff8f69b
Author: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
> fs/proc/task_mmu: avoid spurious seq_file warning on interrupted VMA lookup
>
> Commit 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under
> per-vma lock") introduced the possibility of returning -EINTR from
> proc_get_vma() when a fatal signal interrupts mmap_read_lock_killable().
>
> The issue can be reproduced using stress-ng's VMA stressor, which reads
> /proc/self/maps while concurrently modifying VMAs and periodically
> terminates child processes with SIGKILL. The reproduced command is:
>
> # stress-ng --vma 0 -t 60
>
> When the VMA lookup is interrupted, proc_get_vma() returns an error
> pointer without advancing the position index. Consequently,
> seq_read_iter() emits the following rate-limited informational message:
>
> seq_file: buggy .next function m_next did not update position index
>
> Save the current position in priv->last_pos before checking the VMA
> lookup result, allowing it to be reused by both successful and error
> paths. Advance the position index when returning an error to avoid
> the spurious warning, while preserving the original error handling.
>
> Suggested-by: Lorenzo Stoakes (ARM) <ljs@kernel.org>
> Signed-off-by: Adrian Huang (Lenovo) <adrianhuang0701@gmail.com>
[Severity: Low]
Should this commit include a Fixes tag for the commit it identifies?
Fixes: 5631da56c9a8 ("fs/proc/task_mmu: read proc/pid/maps under per-vma lock")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118103421.776-1-adrianhuang0701@gmail.com?part=1
^ permalink raw reply [flat|nested] 5+ messages in thread