All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Golle <daniel@makrotopia.org>
To: joseph@telaak.dev
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios
Date: Wed, 18 Nov 2026 13:07:16 +0000	[thread overview]
Message-ID: <av2jBEtrEq96xV2-@makrotopia.org> (raw)
In-Reply-To: <20261115-mxl-gsw1xx-reset-v4-2-4ecd18c922e2@telaak.dev>

On Sun, Nov 15, 2026 at 05:33:46PM -0500, Joseph Telaak via B4 Relay wrote:
> From: Joseph Telaak <joseph@telaak.dev>
> 
> The switch keeps the configuration the bootloader left in it, and the
> driver never resets it. The MDIO core asserts and releases reset-gpios
> only for PHY devices, so a reset line described on the switch node has
> no effect either.
> 
> On the GL.iNet GL-SFT1200, nothing answers at internal MDIO address 0
> after the bootloader, and the PHY that answers at each port's address
> belongs to the neighboring port, so port 0 fails with "failed to
> connect to PHY: -ENODEV". Describing the PHYs at the addresses they
> answer at is not enough: with them at 1 to 3 and no reset, neither LAN
> port passes traffic. After a hardware reset every PHY is back at its
> port's address and all ports work. GL.iNet's own firmware resets the
> switch from Linux too.
> 
> Get the reset through the reset controller API and pulse it before the
> first register access. The reset core hands a reset-gpios property to
> the reset-gpio driver, so a board that wires the reset this way needs
> CONFIG_RESET_GPIO; without it the reset is skipped. Imply it, so it is
> enabled by default, and say so in the help text. The timing follows the
> vendor's driver for the GSW150: asserted for 250 ms, then 1 s before the
> switch is accessed. No timing is known for the other GSW1xx parts, so
> they get the same.
> 
> The reset also returns the RGMII slew rates to their power-on defaults,
> so a board that uses reset-gpios sets the ones it needs in its device
> tree.
> 
> Signed-off-by: Joseph Telaak <joseph@telaak.dev>

Reviewed-by: Daniel Golle <daniel@makrotopia.org>

  parent reply	other threads:[~2026-11-18 13:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-15 22:33 [PATCH net-next v4 0/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak via B4 Relay
2026-11-15 22:33 ` Joseph Telaak
2026-11-15 22:33 ` [PATCH net-next v4 1/2] dt-bindings: net: dsa: lantiq,gswip: add reset-gpios Joseph Telaak via B4 Relay
2026-11-15 22:33   ` Joseph Telaak
2026-11-16 22:34   ` sashiko-bot
2026-11-15 22:33 ` [PATCH net-next v4 2/2] net: dsa: mxl-gsw1xx: reset the switch through reset-gpios Joseph Telaak via B4 Relay
2026-11-15 22:33   ` Joseph Telaak
2026-11-18 12:33   ` netdev-bot+sashiko
2026-11-18 20:16     ` Joseph Telaak
2026-11-18 13:07   ` Daniel Golle [this message]
2026-11-19 10:30 ` [PATCH net-next v4 0/2] " patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av2jBEtrEq96xV2-@makrotopia.org \
    --to=daniel@makrotopia.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=hauke@hauke-m.de \
    --cc=joseph@telaak.dev \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=p.zabel@pengutronix.de \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.