All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	James Clark <james.clark@linaro.org>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH v6 03/13] perf annotate: Handle absolute addressing in data type profiling
Date: Wed, 18 Nov 2026 13:15:00 -0300	[thread overview]
Message-ID: <av3PBLtZQ0mYf-1V@phoenix2> (raw)
In-Reply-To: <av1O-I_uLOoY0u5r@google.com>

On Tue, Nov 17, 2026 at 11:08:40PM -0800, Namhyung Kim wrote:
> On Tue, Nov 17, 2026 at 05:04:21PM -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > 
> > 32-bit x86 accesses globals with absolute addresses, like
> > "movl %eax,0x8c73448", but the operand parser only recognized the
> > offset(reg) forms, so the operand had no memory reference, the resolver
> > saw a zero data address and resolved nothing.
> > 
> > Parse a bare "0x" number as an absolute memory operand, leaving jumps,
> > calls, loop* and the 64-bit movabs* out, use the address in the resolver,
> > and let the instruction tracking record the type of an absolute global
> > load in the destination register.  The displacement is sign extended for
> > 64-bit objects, as the CPU does, and zero extended for 32-bit ones.
> > Values that do not fit the int offset, zero, and the operands of
> > relocatable objects, which are unrelocated addends, are skipped.
> > 
> > With bare numbers being memory operands, a frame base register of -1,
> > "none", would also compare equal to the -1 "no register" of an absolute
> > operand and take it for a stack access, so guard those comparisons.
> > Operands left with no register, like a user space "%gs:imm", are no
> > longer looked up as variables, which can change the data type stats of
> > those samples.
> > 
> > Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> >  tools/perf/util/annotate-arch/annotate-x86.c | 52 ++++++++++++++++++--
> >  tools/perf/util/annotate.c                   | 25 +++++++++-
> >  tools/perf/util/annotate.h                   |  7 +++
> >  3 files changed, 79 insertions(+), 5 deletions(-)
> > 
> > diff --git a/tools/perf/util/annotate-arch/annotate-x86.c b/tools/perf/util/annotate-arch/annotate-x86.c
> > index e38a4e7a54d5585c..adb52d148cba6001 100644
> > --- a/tools/perf/util/annotate-arch/annotate-x86.c
> > +++ b/tools/perf/util/annotate-arch/annotate-x86.c
> > @@ -230,6 +230,11 @@ static bool vtable_get_rettype(Dwarf_Die *class_die, int offset,
> >  	return die_get_real_type(&func_die, type_die) != NULL;
> >  }
> >  
> > +static bool is_stack_or_fb_reg(struct type_state *state, int fbreg, int reg)
> > +{
> > +	return (fbreg != -1 && reg == fbreg) || reg == state->stack_reg;
> > +}
> > +
> >  static void update_insn_state_x86(struct type_state *state,
> >  				  struct data_loc_info *dloc, Dwarf_Die *cu_die,
> >  				  struct disasm_line *dl)
> > @@ -437,7 +442,7 @@ static void update_insn_state_x86(struct type_state *state,
> >  		invalidate_reg_state(tsr);
> >  
> >  		/* Case 1: Based on stack pointer or frame pointer */
> > -		if (sreg == fbreg || sreg == state->stack_reg) {
> > +		if (is_stack_or_fb_reg(state, fbreg, sreg)) {
> >  			struct type_state_stack *stack;
> >  			int offset = src->offset - fboff;
> >  
> > @@ -626,7 +631,7 @@ static void update_insn_state_x86(struct type_state *state,
> >  
> >  retry:
> >  		/* Check stack variables with offset */
> > -		if (sreg == fbreg || sreg == state->stack_reg) {
> > +		if (is_stack_or_fb_reg(state, fbreg, sreg)) {
> >  			struct type_state_stack *stack;
> >  			int offset = src->offset - fboff;
> >  
> > @@ -741,6 +746,29 @@ static void update_insn_state_x86(struct type_state *state,
> >  				     insn_offset, addr, dst->reg1);
> >  			pr_debug_type_name(&type_die, tsr->kind);
> >  		}
> > +		/* Or an absolute address, as used by 32-bit code */
> > +		else if (annotated_op_loc__is_abs(src, map__dso(dloc->ms->map))) {
> 
> Then shouldn't it check if it's actually 32-bit code?

After some more rounds of local reviews and trying to answer your
question:
                        /*
                         * Keep only what fits the int, as disp32 or as a u32;
-                        * movabs*, the 64-bit form, is left out.
+                        * a 64-bit absolute value is left out.  The LLVM
+                        * disassembler prints a disp32 that does not fit an
+                        * int as a negative number.
                         */
                        if (offset != 0 && (offset <= UINT_MAX ||
                                            (s64)(int)offset == (s64)offset)) {
-                               /* Absolute address, as used by 32-bit code */
+                               /* An absolute address: 32-bit code, or a 64-bit disp32 */
                                op_loc->mem_ref = true;
                                op_loc->offset = offset;
                        }

It is not 32-bit specific, the comment was wrong.
 
> > +			struct map_symbol *ms = dloc->ms;
> > +			u64 ip = ms->sym->start + dl->al.offset;
> > +			u64 addr = annotated_op_loc__abs_addr(src, map__dso(ms->map));
> > +			int offset;
> > +
> > +			if (!get_global_var_type(cu_die, dloc, ip, addr, &offset,
> > +						 &type_die) ||
> > +			    !die_get_member_type(&type_die, offset, &type_die)) {
> > +				invalidate_reg_state(tsr);
> > +				return;
> > +			}
> > +
> > +			tsr->type = type_die;
> > +			tsr->kind = TSR_KIND_TYPE;
 
> I'm not sure if it's _TYPE at this point.  Probably _POINTER instead?

Why do you think so?

This is just duplicating to some degree what is right before, that uses
a TYPE for a global, no? But please check v7, there is a change in this
area.

- Arnaldo

  reply	other threads:[~2026-11-18 16:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 20:04 [PATCH v6 0/13] perf coverage: A harness for perf, and the fixes it found Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 01/13] perf jvmti: Link the agent with EXTRA_CFLAGS Arnaldo Carvalho de Melo
2026-11-17 20:10   ` sashiko-bot
2026-11-19  7:33   ` Namhyung Kim
2026-11-17 20:04 ` [PATCH v6 02/13] perf scripts: Add a coverage harness for perf Arnaldo Carvalho de Melo
2026-11-17 20:15   ` sashiko-bot
2026-11-18  6:56   ` Namhyung Kim
2026-11-18 21:29     ` Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 03/13] perf annotate: Handle absolute addressing in data type profiling Arnaldo Carvalho de Melo
2026-11-17 20:35   ` sashiko-bot
2026-11-18  7:08   ` Namhyung Kim
2026-11-18 16:15     ` Arnaldo Carvalho de Melo [this message]
2026-11-17 20:04 ` [PATCH v6 04/13] perf tests: Exercise DW_OP_addrx global variables Arnaldo Carvalho de Melo
2026-11-17 20:13   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 05/13] perf tests: Exercise the flexible array member path Arnaldo Carvalho de Melo
2026-11-17 20:11   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 06/13] perf annotate-data: Count flexible array accesses for the whole struct Arnaldo Carvalho de Melo
2026-11-17 20:10   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 07/13] perf tests: Exercise data type resolution from a register Arnaldo Carvalho de Melo
2026-11-17 20:20   ` sashiko-bot
2026-11-18  7:16   ` Namhyung Kim
2026-11-18 16:43     ` Arnaldo Carvalho de Melo
2026-11-17 20:04 ` [PATCH v6 08/13] perf annotate: Print the stats after the annotations Arnaldo Carvalho de Melo
2026-11-17 20:11   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 09/13] perf tests: Silence the libbfd probe in build-test Arnaldo Carvalho de Melo
2026-11-17 20:08   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 10/13] perf build: Record the display-only features in FEATURE-DUMP Arnaldo Carvalho de Melo
2026-11-17 20:15   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 11/13] perf tests: Fix the Intel PT virtual LBR check Arnaldo Carvalho de Melo
2026-11-17 20:18   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 12/13] perf test: Drop samples without an IP in the dlfilter test Arnaldo Carvalho de Melo
2026-11-17 20:12   ` sashiko-bot
2026-11-17 20:04 ` [PATCH v6 13/13] perf test: Skip the LBR inline unwinding check when unsupported Arnaldo Carvalho de Melo
2026-11-17 20:29   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av3PBLtZQ0mYf-1V@phoenix2 \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.