From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: sashiko-reviews@lists.linux.dev
Cc: dri-devel@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Javier Martinez Canillas <javierm@redhat.com>,
Julius Werner <jwerner@chromium.org>,
Sean Rhodes <sean@starlabs.systems>,
Tzung-Bi Shih <tzungbi@kernel.org>
Subject: Re: [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency
Date: Wed, 18 Nov 2026 23:12:06 +0200 [thread overview]
Message-ID: <av4UphaS8l0I5GCY@intel.com> (raw)
In-Reply-To: <sashiko-outbox-221965@kernel.org>
On Wed, Nov 18, 2026 at 09:02:19PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] drm/sysfb: corebootdrm: Fixes trailer cites wrong introducing
> commit
> --
>
> commit bff902d09954dd5579fb286ff3723415928aa52a
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > drm/sysfb: corebootdrm: Fix Kconfig dependency
> >
> > DRM_COREBOOTDRM depends on GOOGLE_FRAMEBUFFER_COREBOOT, which is a
> > transitional stub symbol that can never be enabled. This makes the
> > driver impossible to select. Depend on the real symbol,
> > COREBOOT_FRAMEBUFFER, instead.
> >
> > Fixes: a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers")
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Javier Martinez Canillas <javierm@redhat.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> [Severity: Low]
> Should the Fixes: tag point to 44e33a5aaa2d ("firmware: Rename google
> firmware directory to coreboot") instead?
>
> When a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
> framebuffers") was added, GOOGLE_FRAMEBUFFER_COREBOOT was the active
> symbol and COREBOOT_FRAMEBUFFER did not exist yet. 44e33a5aaa2d
> ("firmware: Rename google firmware directory to coreboot") renamed it to
> COREBOOT_FRAMEBUFFER and turned GOOGLE_FRAMEBUFFER_COREBOOT into a
> promptless transitional stub without updating DRM_COREBOOTDRM, so citing
> a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
> framebuffers") could cause stable backports onto kernels that do not yet
> have COREBOOT_FRAMEBUFFER.
Mea culpa. Didn't trawl the history hard enough.
Cc: Julius Werner <jwerner@chromium.org>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2026-11-18 21:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 20:55 [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency Ville Syrjala
2026-11-18 21:02 ` sashiko-bot
2026-11-18 21:12 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av4UphaS8l0I5GCY@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jwerner@chromium.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sean@starlabs.systems \
--cc=tzimmermann@suse.de \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.