All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Ville Syrjala" <ville.syrjala@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency
Date: Wed, 18 Nov 2026 21:02:19 +0000	[thread overview]
Message-ID: <sashiko-outbox-221965@kernel.org> (raw)
In-Reply-To: <20261118205503.18924-1-ville.syrjala@linux.intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sysfb: corebootdrm: Fixes trailer cites wrong introducing
  commit
--

commit bff902d09954dd5579fb286ff3723415928aa52a
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>

> drm/sysfb: corebootdrm: Fix Kconfig dependency
>
> DRM_COREBOOTDRM depends on GOOGLE_FRAMEBUFFER_COREBOOT, which is a
> transitional stub symbol that can never be enabled. This makes the
> driver impossible to select. Depend on the real symbol,
> COREBOOT_FRAMEBUFFER, instead.
>
> Fixes: a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

[Severity: Low]
Should the Fixes: tag point to 44e33a5aaa2d ("firmware: Rename google
firmware directory to coreboot") instead?

When a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
framebuffers") was added, GOOGLE_FRAMEBUFFER_COREBOOT was the active
symbol and COREBOOT_FRAMEBUFFER did not exist yet.  44e33a5aaa2d
("firmware: Rename google firmware directory to coreboot") renamed it to
COREBOOT_FRAMEBUFFER and turned GOOGLE_FRAMEBUFFER_COREBOOT into a
promptless transitional stub without updating DRM_COREBOOTDRM, so citing
a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
framebuffers") could cause stable backports onto kernels that do not yet
have COREBOOT_FRAMEBUFFER.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118205503.18924-1-ville.syrjala@linux.intel.com?part=1

  reply	other threads:[~2026-11-18 21:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 20:55 [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency Ville Syrjala
2026-11-18 21:02 ` sashiko-bot [this message]
2026-11-18 21:12   ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-221965@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.