* [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency
@ 2026-11-18 20:55 Ville Syrjala
2026-11-18 21:02 ` sashiko-bot
0 siblings, 1 reply; 3+ messages in thread
From: Ville Syrjala @ 2026-11-18 20:55 UTC (permalink / raw)
To: dri-devel; +Cc: Thomas Zimmermann, Javier Martinez Canillas
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
DRM_COREBOOTDRM depends on GOOGLE_FRAMEBUFFER_COREBOOT, which is a
transitional stub symbol that can never be enabled. This makes the
driver impossible to select. Depend on the real symbol,
COREBOOT_FRAMEBUFFER, instead.
Fixes: a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers")
Cc: Thomas Zimmermann <tzimmermann@suse.de>
Cc: Javier Martinez Canillas <javierm@redhat.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
Claude spotted this while we were looking for extra things to
enable in my drm-misc kernel build config.
drivers/gpu/drm/sysfb/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sysfb/Kconfig b/drivers/gpu/drm/sysfb/Kconfig
index f7e48178885e..2bfcd59bfe6d 100644
--- a/drivers/gpu/drm/sysfb/Kconfig
+++ b/drivers/gpu/drm/sysfb/Kconfig
@@ -10,7 +10,7 @@ config DRM_SYSFB_HELPER
config DRM_COREBOOTDRM
tristate "Coreboot framebuffer driver"
depends on DRM && MMU
- depends on GOOGLE_FRAMEBUFFER_COREBOOT
+ depends on COREBOOT_FRAMEBUFFER
select APERTURE_HELPERS
select DRM_CLIENT_SELECTION
select DRM_GEM_SHMEM_HELPER
--
2.56.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency
2026-11-18 20:55 [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency Ville Syrjala
@ 2026-11-18 21:02 ` sashiko-bot
2026-11-18 21:12 ` Ville Syrjälä
0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-11-18 21:02 UTC (permalink / raw)
To: Ville Syrjala, dri-devel
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/sysfb: corebootdrm: Fixes trailer cites wrong introducing
commit
--
commit bff902d09954dd5579fb286ff3723415928aa52a
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> drm/sysfb: corebootdrm: Fix Kconfig dependency
>
> DRM_COREBOOTDRM depends on GOOGLE_FRAMEBUFFER_COREBOOT, which is a
> transitional stub symbol that can never be enabled. This makes the
> driver impossible to select. Depend on the real symbol,
> COREBOOT_FRAMEBUFFER, instead.
>
> Fixes: a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers")
> Cc: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
[Severity: Low]
Should the Fixes: tag point to 44e33a5aaa2d ("firmware: Rename google
firmware directory to coreboot") instead?
When a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
framebuffers") was added, GOOGLE_FRAMEBUFFER_COREBOOT was the active
symbol and COREBOOT_FRAMEBUFFER did not exist yet. 44e33a5aaa2d
("firmware: Rename google firmware directory to coreboot") renamed it to
COREBOOT_FRAMEBUFFER and turned GOOGLE_FRAMEBUFFER_COREBOOT into a
promptless transitional stub without updating DRM_COREBOOTDRM, so citing
a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
framebuffers") could cause stable backports onto kernels that do not yet
have COREBOOT_FRAMEBUFFER.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118205503.18924-1-ville.syrjala@linux.intel.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency
2026-11-18 21:02 ` sashiko-bot
@ 2026-11-18 21:12 ` Ville Syrjälä
0 siblings, 0 replies; 3+ messages in thread
From: Ville Syrjälä @ 2026-11-18 21:12 UTC (permalink / raw)
To: sashiko-reviews
Cc: dri-devel, Thomas Zimmermann, Javier Martinez Canillas,
Julius Werner, Sean Rhodes, Tzung-Bi Shih
On Wed, Nov 18, 2026 at 09:02:19PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue to consider:
> - [Low] drm/sysfb: corebootdrm: Fixes trailer cites wrong introducing
> commit
> --
>
> commit bff902d09954dd5579fb286ff3723415928aa52a
> Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> > drm/sysfb: corebootdrm: Fix Kconfig dependency
> >
> > DRM_COREBOOTDRM depends on GOOGLE_FRAMEBUFFER_COREBOOT, which is a
> > transitional stub symbol that can never be enabled. This makes the
> > driver impossible to select. Depend on the real symbol,
> > COREBOOT_FRAMEBUFFER, instead.
> >
> > Fixes: a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot framebuffers")
> > Cc: Thomas Zimmermann <tzimmermann@suse.de>
> > Cc: Javier Martinez Canillas <javierm@redhat.com>
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> [Severity: Low]
> Should the Fixes: tag point to 44e33a5aaa2d ("firmware: Rename google
> firmware directory to coreboot") instead?
>
> When a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
> framebuffers") was added, GOOGLE_FRAMEBUFFER_COREBOOT was the active
> symbol and COREBOOT_FRAMEBUFFER did not exist yet. 44e33a5aaa2d
> ("firmware: Rename google firmware directory to coreboot") renamed it to
> COREBOOT_FRAMEBUFFER and turned GOOGLE_FRAMEBUFFER_COREBOOT into a
> promptless transitional stub without updating DRM_COREBOOTDRM, so citing
> a29a1f0ec8d6 ("drm/sysfb: corebootdrm: Add DRM driver for coreboot
> framebuffers") could cause stable backports onto kernels that do not yet
> have COREBOOT_FRAMEBUFFER.
Mea culpa. Didn't trawl the history hard enough.
Cc: Julius Werner <jwerner@chromium.org>
Cc: Sean Rhodes <sean@starlabs.systems>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-18 21:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-18 20:55 [PATCH] drm/sysfb: corebootdrm: Fix Kconfig dependency Ville Syrjala
2026-11-18 21:02 ` sashiko-bot
2026-11-18 21:12 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.