From: Oleg Nesterov <oleg@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Allison Henderson <achender@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Joel Granados <joel.granados@kernel.org>,
edumazet@google.com, horms@kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 net-next 0/5] net/rds: move sysctl-only code under CONFIG_SYSCTL
Date: Thu, 19 Nov 2026 10:42:07 +0100 [thread overview]
Message-ID: <av7EbwREaye6QQnQ@redhat.com> (raw)
In-Reply-To: <20261118181936.2f6e9d7b@kernel.org>
On 11/18, Jakub Kicinski wrote:
>
> On Sun, 15 Nov 2026 14:24:40 +0100 Oleg Nesterov wrote:
> > Compile tested with CONFIG_RDS CONFIG_RDS_RDMA CONFIG_RDS_TCP CONFIG_RDS_DEBUG,
> > the kernel builds with or without CONFIG_SYSCTL.
>
> Why tho?
Well, initially I proposed these changes to fix the bug with CONFIG_SYSCTL=n
but Allison found a much simpler solution, commit fbea154a86641d25
So I sent V1 on top of that fix with the following note in 0/5
Allison, Joel, I am sending this mostly to "complete" the previous discussions.
I won't argue if you think these cleanups do not make a lot of sense.
and you suggested to rebase on net-next/main and resend after
the merge window.
That is why ;)
> Who cares about this? How much is this series improving
> the life for those who care? Otherwise it looks like pure noise
> and a bunch of ifdefs we were happily living without until now.
OK, please forget then. Cleanups are always subjective, and I agree
that this series doesn't really "improve" the code.
Thanks!
Oleg.
prev parent reply other threads:[~2026-11-19 9:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-15 13:24 [PATCH v2 net-next 0/5] net/rds: move sysctl-only code under CONFIG_SYSCTL Oleg Nesterov
2026-11-15 13:25 ` [PATCH v2 net-next 1/5] net/rds/sysctl.c: " Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 2/5] net/rds/ib_sysctl.c: " Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 3/5] net/rds/tcp.c: introduce rds_tcp_{init,exit}_net_sysctl() helpers Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 4/5] net/rds/tcp.c: move sysctl-only code under CONFIG_SYSCTL Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-15 13:25 ` [PATCH v2 net-next 5/5] net/rds: remove dead sysctl declarations Oleg Nesterov
2026-11-15 13:32 ` sashiko-bot
2026-11-19 2:19 ` [PATCH v2 net-next 0/5] net/rds: move sysctl-only code under CONFIG_SYSCTL Jakub Kicinski
2026-11-19 9:42 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=av7EbwREaye6QQnQ@redhat.com \
--to=oleg@redhat.com \
--cc=achender@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joel.granados@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.