All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <me@ziyao.cc>
To: "Rong Zhang" <rongrong@oss.cipunited.com>,
	"Keguang Zhang" <keguang.zhang@gmail.com>,
	"Wim Van Sebroeck" <wim@linux-watchdog.org>,
	"Guenter Roeck" <linux@roeck-us.net>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>
Cc: "Rong Zhang" <i@rong.moe>, "Yao Zi" <me@ziyao.cc>,
	"Icenowy Zheng" <uwu@icenowy.me>,
	"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
	<linux-mips@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/8] MIPS: Loongson64: dts: ls7a-pch: Add miscellaneous clock node
Date: Thu, 19 Nov 2026 12:19:57 +0000	[thread overview]
Message-ID: <av7pbVpkdO8dFGH7@pie> (raw)
In-Reply-To: <20261113-mips-ls7a-wdt-v2-5-e8abd6b2f77c@oss.cipunited.com>

On Fri, Nov 13, 2026 at 06:51:12PM +0800, Rong Zhang wrote:
> The Loongson-7A has an internal clock source for miscellaneous
> peripherals. The clock source is nonconfigurable and has a fixed 50MHz
> clock frequency.
> 
> Add a 50MHz fixed-clock node with label "pch_misc_clk" to represent it.
> 
> Signed-off-by: Rong Zhang <rongrong@oss.cipunited.com>
> ---
>  arch/mips/boot/dts/loongson/ls7a-pch.dtsi | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> index 9f0a183bd348..2ef1ad10a8ec 100644
> --- a/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> +++ b/arch/mips/boot/dts/loongson/ls7a-pch.dtsi
> @@ -1,6 +1,12 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
>  / {
> +	pch_misc_clk: clock-50000000 {
> +		#clock-cells = <0>;
> +		compatible = "fixed-clock";
> +		clock-frequency = <50000000>;

"compatible" property usually comes before other properties other than
"device_type", see dts-coding-style.rst.

With this fixed,

Reviewed-by: Yao Zi <me@ziyao.cc>

> +	};
> +
>  	pch: bus@10000000 {
>  		compatible = "simple-bus";
>  		#address-cells = <2>;
> 
> -- 
> 2.55.0

-- 
Thanks,
Yao Zi

Meow-mrrp-mrow, I'm a cat.

  reply	other threads:[~2026-11-19 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-13 10:51 [PATCH v2 0/8] watchdog: loongson1: Add Loongson-7A watchdog support Rong Zhang
2026-11-13 10:51 ` [PATCH v2 1/8] dt-bindings: watchdog: loongson,ls1x-wdt: Add compatible for Loongson-7A Rong Zhang
2026-11-13 17:17   ` Conor Dooley
2026-11-14 17:15   ` Guenter Roeck
2026-11-13 10:51 ` [PATCH v2 2/8] MIPS: Loongson64: env: Don't warn if UART has clocks node when fixing up FDT Rong Zhang
2026-11-13 10:51 ` [PATCH v2 3/8] MIPS: Loongson64: dts: ls7a-pch: Add missing #address-cells to interrupt controllers Rong Zhang
2026-11-13 11:01   ` sashiko-bot
2026-11-17  7:53     ` Rong Zhang
2026-11-13 10:51 ` [PATCH v2 4/8] MIPS: Loongson64: dts: ls7a-pch: Use hex in ranges and reg properties Rong Zhang
2026-11-13 10:51 ` [PATCH v2 5/8] MIPS: Loongson64: dts: ls7a-pch: Add miscellaneous clock node Rong Zhang
2026-11-19 12:19   ` Yao Zi [this message]
2026-11-13 10:51 ` [PATCH v2 6/8] MIPS: Loongson64: dts: ls7a-pch: Bind UART nodes to miscellaneous clock Rong Zhang
2026-11-13 10:51 ` [PATCH v2 7/8] MIPS: Loongson64: dts: ls7a-pch: Add watchdog node Rong Zhang
2026-11-13 10:51 ` [PATCH v2 8/8] MIPS: loongson3_defconfig: Enable LOONGSON1_WDT by default Rong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av7pbVpkdO8dFGH7@pie \
    --to=me@ziyao.cc \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=i@rong.moe \
    --cc=jiaxun.yang@flygoat.com \
    --cc=keguang.zhang@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=robh@kernel.org \
    --cc=rongrong@oss.cipunited.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=uwu@icenowy.me \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.