* [PATCH] drm/bridge: analogix_dp: Fix runtime PM reference leak in set_bridge
[not found] <CGME20261119093353eucas1p1de9688c7e1847ae8266690934b09f925@eucas1p1.samsung.com>
@ 2026-11-19 9:33 ` Marek Szyprowski
2026-11-19 18:02 ` Brian Norris
0 siblings, 1 reply; 3+ messages in thread
From: Marek Szyprowski @ 2026-11-19 9:33 UTC (permalink / raw)
To: dri-devel
Cc: Marek Szyprowski, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Damon Ding,
Dmitry Baryshkov, Heiko Stuebner, Douglas Anderson, Brian Norris
analogix_dp_set_bridge() takes a runtime PM reference at the beginning,
but returns directly without dropping it when
analogix_dp_init_analog_func() fails. Jump to the common error path
instead, which drops the reference.
Fixes: 3efe2ace7f5b ("drm/bridge: analogix_dp: move basic controller init into runtime PM")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 022acb962b7c..84951413012b 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -998,7 +998,7 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
ret = analogix_dp_init_analog_func(dp);
if (ret)
- return ret;
+ goto out_dp_init;
/*
* According to DP spec v1.3 chap 3.5.1.2 Link Training,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Fix runtime PM reference leak in set_bridge
2026-11-19 9:33 ` [PATCH] drm/bridge: analogix_dp: Fix runtime PM reference leak in set_bridge Marek Szyprowski
@ 2026-11-19 18:02 ` Brian Norris
2026-11-20 2:15 ` Damon Ding
0 siblings, 1 reply; 3+ messages in thread
From: Brian Norris @ 2026-11-19 18:02 UTC (permalink / raw)
To: Marek Szyprowski
Cc: dri-devel, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Damon Ding,
Dmitry Baryshkov, Heiko Stuebner, Douglas Anderson
On Thu, Nov 19, 2026 at 10:33:46AM +0100, Marek Szyprowski wrote:
> analogix_dp_set_bridge() takes a runtime PM reference at the beginning,
> but returns directly without dropping it when
> analogix_dp_init_analog_func() fails. Jump to the common error path
> instead, which drops the reference.
>
> Fixes: 3efe2ace7f5b ("drm/bridge: analogix_dp: move basic controller init into runtime PM")
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index 022acb962b7c..84951413012b 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -998,7 +998,7 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
>
> ret = analogix_dp_init_analog_func(dp);
This function never fails, in fact. So this patch is just an academic
exercise.
Personally, I'd prefer you just make analogix_dp_init_analog_func()
return void, to simplify things.
Brian
> if (ret)
> - return ret;
> + goto out_dp_init;
>
> /*
> * According to DP spec v1.3 chap 3.5.1.2 Link Training,
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Fix runtime PM reference leak in set_bridge
2026-11-19 18:02 ` Brian Norris
@ 2026-11-20 2:15 ` Damon Ding
0 siblings, 0 replies; 3+ messages in thread
From: Damon Ding @ 2026-11-20 2:15 UTC (permalink / raw)
To: Brian Norris, Marek Szyprowski
Cc: dri-devel, Andrzej Hajda, Neil Armstrong, Robert Foss,
Laurent Pinchart, Jonas Karlman, Jernej Skrabec, Luca Ceresoli,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Dmitry Baryshkov, Heiko Stuebner, Douglas Anderson
On 11/20/2026 2:02 AM, Brian Norris wrote:
> On Thu, Nov 19, 2026 at 10:33:46AM +0100, Marek Szyprowski wrote:
>> analogix_dp_set_bridge() takes a runtime PM reference at the beginning,
>> but returns directly without dropping it when
>> analogix_dp_init_analog_func() fails. Jump to the common error path
>> instead, which drops the reference.
>>
>> Fixes: 3efe2ace7f5b ("drm/bridge: analogix_dp: move basic controller init into runtime PM")
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> index 022acb962b7c..84951413012b 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
>> @@ -998,7 +998,7 @@ static int analogix_dp_set_bridge(struct analogix_dp_device *dp)
>>
>> ret = analogix_dp_init_analog_func(dp);
>
> This function never fails, in fact. So this patch is just an academic
> exercise.
>
> Personally, I'd prefer you just make analogix_dp_init_analog_func()
> return void, to simplify things.
>
I agree with Brian, that sounds like a cleaner approach.
Best regards,
Damon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-11-20 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20261119093353eucas1p1de9688c7e1847ae8266690934b09f925@eucas1p1.samsung.com>
2026-11-19 9:33 ` [PATCH] drm/bridge: analogix_dp: Fix runtime PM reference leak in set_bridge Marek Szyprowski
2026-11-19 18:02 ` Brian Norris
2026-11-20 2:15 ` Damon Ding
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.