All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mm/backing-dev: pass "%s" format string to device_create() in bdi_register_va()
@ 2026-11-19 17:05 Ian Rogers
  2026-11-19 18:26 ` Lorenzo Stoakes (ARM)
  2026-11-19 18:38 ` + mm-backing-dev-pass-%s-format-string-to-device_create-in-bdi_register_va.patch added to mm-new branch Andrew Morton
  0 siblings, 2 replies; 3+ messages in thread
From: Ian Rogers @ 2026-11-19 17:05 UTC (permalink / raw)
  To: Andrew Morton, David Hildenbrand
  Cc: Lorenzo Stoakes, Liam R. Howlett, Vlastimil Babka, Mike Rapoport,
	Suren Baghdasaryan, Michal Hocko, linux-mm, linux-kernel, llvm,
	Elkin Cruz, Ian Rogers

bdi_register_va() formats (fmt, args) into bdi->dev_name via vsnprintf()
and then passes bdi->dev_name directly as the format string argument to
device_create(), causing vsnprintf() to run a second time on the already
formatted device name with no variadic arguments. If a caller formats an
identifier containing '%', device_create() interprets it as format
specifiers and reads arbitrary stack slots.

Pass "%s", bdi->dev_name to device_create().

Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
-Wformat-security enabled; fix and changelog drafted with an AI coding
assistant. Build-tested under LLVM=1 W=1 and -Wformat-security; not
runtime-tested with '%' in backing-device names.

Fixes: 6bd87eec23cb ("bdi: add a ->dev_name field to struct backing_dev_info")
Signed-off-by: Ian Rogers <irogers@google.com>
---
 mm/backing-dev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index fad1495d3b20..58373d494d92 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -1097,7 +1097,8 @@ int bdi_register_va(struct backing_dev_info *bdi, const char *fmt, va_list args)
 		return 0;
 
 	vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args);
-	dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name);
+	dev = device_create(&bdi_class, NULL, MKDEV(0, 0), bdi, "%s",
+			    bdi->dev_name);
 	if (IS_ERR(dev))
 		return PTR_ERR(dev);
 
-- 
2.56.1.708.g77570a6a1d-goog


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-19 18:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-19 17:05 [PATCH] mm/backing-dev: pass "%s" format string to device_create() in bdi_register_va() Ian Rogers
2026-11-19 18:26 ` Lorenzo Stoakes (ARM)
2026-11-19 18:38 ` + mm-backing-dev-pass-%s-format-string-to-device_create-in-bdi_register_va.patch added to mm-new branch Andrew Morton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.